Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2947593003: Fix an incorrect method name on the chrome://site-engagement WebUI page. (Closed)

Created:
3 years, 6 months ago by dominickn
Modified:
3 years, 6 months ago
Reviewers:
tsergeant, calamity
CC:
chromium-reviews, arv+watch_chromium.org
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Fix an incorrect method name on the chrome://site-engagement WebUI page. TBR=calamity@chromium.org BUG=730434 NOTRY=true NOPRESUBMIT=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2947593003 Cr-Commit-Position: refs/branch-heads/3071@{#801} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/d5baec557d94596cef90ba652dbbe546bc6ab5ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/engagement/site_engagement.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
dominickn
+tsergeant for sanity check. Refer to https://codereview.chromium.org/2788413003 for the patch that introduced this bug, and ...
3 years, 6 months ago (2017-06-19 00:23:44 UTC) #4
tsergeant
lgtm
3 years, 6 months ago (2017-06-19 00:38:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2947593003/1
3 years, 6 months ago (2017-06-19 00:41:30 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-19 00:42:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d5baec557d94596cef90ba652dbb...

Powered by Google App Engine
This is Rietveld 408576698