[SiteEngagement WebUI] Replace C++ browser test with JS version.

[SiteEngagement WebUI] Replace C++ browser test with JS version.

BUG=703848
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2811643002
Cr-Commit-Position: refs/heads/master@{#467916}
Committed: https://chromium.googlesource.com/chromium/src/+/6c540a0cf80885708e1b5bb5f9c2c04082e6b0c1

[calamity, 2017-04-10 08:19:16]

Description was changed from

==========
[SiteEngagement WebUI] Replace C++ browser test with JS version.

BUG=703848
==========

to

==========
[SiteEngagement WebUI] Replace C++ browser test with JS version.

BUG=703848
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[calamity, 2017-04-10 08:23:40]

Patchset #1 (id:1) has been deleted

[calamity, 2017-04-10 08:26:48]

Patchset #1 (id:20001) has been deleted

[calamity, 2017-04-10 08:27:13]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[dominickn, 2017-04-10 10:41:22]

As discussed offline, we'll hold off on landing this one until Wez's set of CLs
are landed (since we need his work for M59, while this can hold off till M60).

[calamity, 2017-04-27 03:07:20]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 03:08:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 04:43:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 04:43:22]

Dry run: This issue passed the CQ dry run.

[calamity, 2017-04-27 07:00:32]

@tsergeant, this is ready for review.

[tsergeant, 2017-04-27 07:32:39]

lgtm

https://codereview.chromium.org/2811643002/diff/80001/chrome/test/data/webui/...
File chrome/test/data/webui/engagement/site_engagement_browsertest.js (right):

https://codereview.chromium.org/2811643002/diff/80001/chrome/test/data/webui/...
chrome/test/data/webui/engagement/site_engagement_browsertest.js:50:
suite('chrome://site-engagement', function() {
nit: You don't really need the suite here, since there's no setup(). You can
just have the two test() functions directly.

[calamity, 2017-04-28 04:40:28]

https://codereview.chromium.org/2811643002/diff/80001/chrome/test/data/webui/...
File chrome/test/data/webui/engagement/site_engagement_browsertest.js (right):

https://codereview.chromium.org/2811643002/diff/80001/chrome/test/data/webui/...
chrome/test/data/webui/engagement/site_engagement_browsertest.js:50:
suite('chrome://site-engagement', function() {
On 2017/04/27 07:32:39, tsergeant wrote:
> nit: You don't really need the suite here, since there's no setup(). You can
> just have the two test() functions directly.

Done.

[calamity, 2017-04-28 05:05:40]

The CQ bit was checked by calamity@chromium.org

[calamity, 2017-04-28 05:05:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2811643002/#ps100001
(title: "fixnit")

[commit-bot: I haz the power, 2017-04-28 05:06:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 06:12:32]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1493355940430900,
"parent_rev": "87ff6dd93ccb11c339b9f9278b6d2ce18a05f32d", "commit_rev":
"6c540a0cf80885708e1b5bb5f9c2c04082e6b0c1"}

[commit-bot: I haz the power, 2017-04-28 06:12:40]

Description was changed from

==========
[SiteEngagement WebUI] Replace C++ browser test with JS version.

BUG=703848
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[SiteEngagement WebUI] Replace C++ browser test with JS version.

BUG=703848
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2811643002
Cr-Commit-Position: refs/heads/master@{#467916}
Committed:
https://chromium.googlesource.com/chromium/src/+/6c540a0cf80885708e1b5bb5f9c2...
==========

[commit-bot: I haz the power, 2017-04-28 06:12:41]

Committed patchset #4 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/6c540a0cf80885708e1b5bb5f9c2...