Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 2947013003: Remove PermissionQueueController queueing checks in PermissionNavigationTest (Closed)

Created:
3 years, 6 months ago by Timothy Loh
Modified:
3 years, 6 months ago
Reviewers:
dominickn
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, raymes+watch_chromium.org, agrieve+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove PermissionQueueController queueing checks in PermissionNavigationTest When we enable the PermissionRequestManager on Android, the queueing in the PermissionQueueController will no longer be relevant, as different permission types will be queued by the PRM. To make the flag flip easier this patch removes the checks in PermissionNavigationTest for queueing, which would otherwise need to be removed at the same time as the flip. BUG=606138 Review-Url: https://codereview.chromium.org/2947013003 Cr-Commit-Position: refs/heads/master@{#481127} Committed: https://chromium.googlesource.com/chromium/src/+/95f41c431169a0dc380402e6cccb5a48e3fb486a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogController.java View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/permissions/PermissionNavigationTest.java View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Timothy Loh
Maybe I should've planned ahead more and not added these checks in the test...
3 years, 6 months ago (2017-06-21 03:30:51 UTC) #4
dominickn
On 2017/06/21 03:30:51, Timothy Loh wrote: > Maybe I should've planned ahead more and not ...
3 years, 6 months ago (2017-06-21 03:36:25 UTC) #5
Timothy Loh
On 2017/06/21 03:36:25, dominickn wrote: > On 2017/06/21 03:30:51, Timothy Loh wrote: > > Maybe ...
3 years, 6 months ago (2017-06-21 03:51:03 UTC) #6
dominickn
Fair enough. lgtm
3 years, 6 months ago (2017-06-21 04:05:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2947013003/1
3 years, 6 months ago (2017-06-21 06:37:24 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 06:42:35 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/95f41c431169a0dc380402e6cccb...

Powered by Google App Engine
This is Rietveld 408576698