Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4565)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/permissions/PermissionNavigationTest.java

Issue 2947013003: Remove PermissionQueueController queueing checks in PermissionNavigationTest (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogController.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/permissions/PermissionNavigationTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/PermissionNavigationTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/PermissionNavigationTest.java
index fe0168b218d375b0c36744f4e4f11f5f4ce08712..b3eb1e926853080d46a0aaca3d692ad29c131827 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/PermissionNavigationTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/PermissionNavigationTest.java
@@ -6,15 +6,12 @@ package org.chromium.chrome.browser.permissions;
import android.support.test.filters.MediumTest;
-import org.junit.Assert;
-
import org.chromium.base.test.util.CallbackHelper;
import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.RetryOnFailure;
import org.chromium.chrome.browser.tab.EmptyTabObserver;
import org.chromium.chrome.browser.tab.Tab;
-import org.chromium.content.browser.test.util.Criteria;
import org.chromium.content.browser.test.util.CriteriaHelper;
/**
@@ -40,15 +37,6 @@ public class PermissionNavigationTest extends PermissionTestCaseBase {
runJavaScriptCodeInCurrentTab("requestGeolocationPermission()");
DialogShownCriteria criteriaShown = new DialogShownCriteria("Dialog not shown", true);
CriteriaHelper.pollUiThread(criteriaShown);
- Assert.assertEquals(0, PermissionDialogController.getInstance().getQueueLengthForTesting());
-
- runJavaScriptCodeInCurrentTab("requestNotificationPermission()");
- CriteriaHelper.pollInstrumentationThread(new Criteria("Request not queued") {
- @Override
- public boolean isSatisfied() {
- return PermissionDialogController.getInstance().getQueueLengthForTesting() == 1;
- }
- });
runJavaScriptCodeInCurrentTab("navigate()");
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogController.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698