Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2946953002: Revert of [parser] Forbid \08 in strict strings (Closed)

Created:
3 years, 6 months ago by Michael Achenbach
Modified:
3 years, 6 months ago
Reviewers:
vogelheim, bakkot1
CC:
v8-reviews_googlegroups.com, marja+watch_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [parser] Forbid \08 in strict strings (patchset #3 id:40001 of https://codereview.chromium.org/2950633002/ ) Reason for revert: Breaks layout test: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/16403 See: https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > [parser] Forbid \08 in strict strings and in untagged templates > > This was never legal; the spec only allows '\0' in strict-mode strings or templates > when not followed by a decimal digit. Previously we were only enforcing that it > not be followed by an _octal_ digit. > > This was already fixed for numeric literals, but not for escape sequences in strings. > > BUG=v8:6504 > > Review-Url: https://codereview.chromium.org/2950633002 > Cr-Commit-Position: refs/heads/master@{#46046} > Committed: https://chromium.googlesource.com/v8/v8/+/b102540e44a72157098014a20399193a461153d2 TBR=vogelheim@chromium.org,bakkot@gmail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6504 Review-Url: https://codereview.chromium.org/2946953002 Cr-Commit-Position: refs/heads/master@{#46068} Committed: https://chromium.googlesource.com/v8/v8/+/c3f2c5ef8df7595fcf27bbcc27be32851b74c6af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -31 lines) Patch
M src/parsing/scanner.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 3 chunks +0 lines, -29 lines 0 comments Download
M test/mjsunit/es6/templates.js View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [parser] Forbid \08 in strict strings
3 years, 6 months ago (2017-06-20 18:23:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2946953002/1
3 years, 6 months ago (2017-06-20 18:23:54 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 18:24:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c3f2c5ef8df7595fcf27bbcc27be32851b7...

Powered by Google App Engine
This is Rietveld 408576698