[parser] Forbid \08 in strict strings

[parser] Forbid \08 in strict strings and in untagged templates

This was never legal; the spec only allows '\0' in strict-mode strings or templates
when not followed by a decimal digit. Previously we were only enforcing that it
not be followed by an _octal_ digit.

This was already fixed for numeric literals, but not for escape sequences in strings.

BUG=v8:6504
Review-Url: https://codereview.chromium.org/2950633002
Cr-Commit-Position: refs/heads/master@{#46046}
Committed: https://chromium.googlesource.com/v8/v8/+/b102540e44a72157098014a20399193a461153d2

[bakkot1, 2017-06-19 21:11:44]

Description was changed from

==========
[parser] Forbid \08 in strict strings

BUG=v8:6504
==========

to

==========
[parser] Forbid \08 in strict strings

BUG=v8:6504
==========

[bakkot1, 2017-06-19 21:11:44]

bakkot@gmail.com changed reviewers:
+ vogelheim@chromium.org

[bakkot1, 2017-06-19 21:12:14]

Description was changed from

==========
[parser] Forbid \08 in strict strings

BUG=v8:6504
==========

to

==========
[parser] Forbid \08 in strict strings and in untagged templates

BUG=v8:6504
==========

[bakkot1, 2017-06-19 21:14:19]

PTAL. See bug for spec; short version: spec allows `\0` in strict-mode strings
and template literals only when not followed by a decimal digit. Previously we
were only enforcing that it not be followed by an *octal* digit.

[bakkot1, 2017-06-19 21:34:30]

Description was changed from

==========
[parser] Forbid \08 in strict strings and in untagged templates

BUG=v8:6504
==========

to

==========
[parser] Forbid \08 in strict strings and in untagged templates

This was never legal; the spec only allows '\0' in strict-mode strings or
templates
when not followed by a decimal digit. Previously we were only enforcing that it
not be followed by an _octal_ digit.

This was already fixed for numeric literals, but not for escape sequences in
strings.

BUG=v8:6504
==========

[vogelheim, 2017-06-20 08:50:33]

lgtm. Thanks for the tests!

[bakkot1, 2017-06-20 12:55:42]

The CQ bit was checked by bakkot@gmail.com

[commit-bot: I haz the power, 2017-06-20 12:55:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 13:28:17]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497963342270430,
"parent_rev": "c0f1ff2451b43cbc4b1ae9f668b616173877285a", "commit_rev":
"b102540e44a72157098014a20399193a461153d2"}

[commit-bot: I haz the power, 2017-06-20 13:28:27]

Description was changed from

==========
[parser] Forbid \08 in strict strings and in untagged templates

This was never legal; the spec only allows '\0' in strict-mode strings or
templates
when not followed by a decimal digit. Previously we were only enforcing that it
not be followed by an _octal_ digit.

This was already fixed for numeric literals, but not for escape sequences in
strings.

BUG=v8:6504
==========

to

==========
[parser] Forbid \08 in strict strings and in untagged templates

This was never legal; the spec only allows '\0' in strict-mode strings or
templates
when not followed by a decimal digit. Previously we were only enforcing that it
not be followed by an _octal_ digit.

This was already fixed for numeric literals, but not for escape sequences in
strings.

BUG=v8:6504

Review-Url: https://codereview.chromium.org/2950633002
Cr-Commit-Position: refs/heads/master@{#46046}
Committed:
https://chromium.googlesource.com/v8/v8/+/b102540e44a72157098014a20399193a461...
==========

[commit-bot: I haz the power, 2017-06-20 13:28:27]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/b102540e44a72157098014a20399193a461...

[Michael Achenbach, 2017-06-20 18:23:43]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2946953002/ by machenbach@chromium.org.

The reason for reverting is: Breaks layout test:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...

See:
https://github.com/v8/v8/wiki/Blink-layout-tests.

[Michael Achenbach, 2017-06-20 18:25:02]

"Breaks" seems to be "fixes" in this case. The CL still needs to go through the
layout-test rebase dance.