Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Issue 2946323003: Page Info: Add brackets in to one line if and for statements (Closed)

Created:
3 years, 6 months ago by sperigo
Modified:
3 years, 6 months ago
Reviewers:
lgarron
CC:
chromium-reviews, lgarron+watch_chromium.org, meacer, raymes+watch_chromium.org, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Page Info: Add brackets in to one line if and for statements BUG=699840 Review-Url: https://codereview.chromium.org/2946323003 Cr-Commit-Position: refs/heads/master@{#481409} Committed: https://chromium.googlesource.com/chromium/src/+/1e5352e7505feac546757f8bcdd7217b09a136a0

Patch Set 1 #

Patch Set 2 : Added "Page Info:", clarifying the scope of the change, into the commit message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -26 lines) Patch
M chrome/browser/ui/views/page_info/chosen_object_row.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/page_info/page_info_bubble_view.cc View 9 chunks +32 lines, -16 lines 0 comments Download
M chrome/browser/ui/views/page_info/page_info_bubble_view_unittest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/page_info/permission_selector_row.cc View 4 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
sperigo
I went ahead and tackled bug #699840 which involved addressing a code style issue.
3 years, 6 months ago (2017-06-22 00:11:49 UTC) #2
lgarron
Thanks, this will make me happier to work on this code! :-D LGTM
3 years, 6 months ago (2017-06-22 00:30:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2946323003/1
3 years, 6 months ago (2017-06-22 00:30:50 UTC) #5
lgarron
I originally sent this to the commit queue, but first one nit: Could you add ...
3 years, 6 months ago (2017-06-22 00:35:07 UTC) #7
sperigo
On 2017/06/22 00:35:07, lgarron wrote: > I originally sent this to the commit queue, but ...
3 years, 6 months ago (2017-06-22 00:41:53 UTC) #11
lgarron
On 2017/06/22 at 00:41:53, sperigo wrote: > On 2017/06/22 00:35:07, lgarron wrote: > > I ...
3 years, 6 months ago (2017-06-22 00:42:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2946323003/20001
3 years, 6 months ago (2017-06-22 00:42:46 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 02:29:01 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1e5352e7505feac546757f8bcdd7...

Powered by Google App Engine
This is Rietveld 408576698