Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6277)

Unified Diff: chrome/browser/ui/views/page_info/page_info_bubble_view_unittest.cc

Issue 2946323003: Page Info: Add brackets in to one line if and for statements (Closed)
Patch Set: Added "Page Info:", clarifying the scope of the change, into the commit message Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/page_info/page_info_bubble_view_unittest.cc
diff --git a/chrome/browser/ui/views/page_info/page_info_bubble_view_unittest.cc b/chrome/browser/ui/views/page_info/page_info_bubble_view_unittest.cc
index 22586d25e7479b596ddbe3ef6c86673300ad2d7e..c7edecd645bda193871c0336dc787329f3705ef3 100644
--- a/chrome/browser/ui/views/page_info/page_info_bubble_view_unittest.cc
+++ b/chrome/browser/ui/views/page_info/page_info_bubble_view_unittest.cc
@@ -44,8 +44,9 @@ class PageInfoBubbleViewTestApi {
}
void CreateView() {
- if (view_)
+ if (view_) {
view_->GetWidget()->CloseNow();
+ }
security_state::SecurityInfo security_info;
views::View* anchor_view = nullptr;
@@ -65,8 +66,9 @@ class PageInfoBubbleViewTestApi {
// |label_| element isn't actually a |views::Label|.
base::string16 GetPermissionLabelTextAt(int index) {
views::View* view = GetPermissionSelectorAt(index)->label_;
- if (view->GetClassName() == views::Label::kViewClassName)
+ if (view->GetClassName() == views::Label::kViewClassName) {
return static_cast<views::Label*>(view)->text();
+ }
return base::string16();
}
@@ -85,8 +87,9 @@ class PageInfoBubbleViewTestApi {
// Simulates recreating the dialog with a new PermissionInfoList.
void SetPermissionInfo(const PermissionInfoList& list) {
- for (const PageInfoBubbleView::PermissionInfo& info : list)
+ for (const PageInfoBubbleView::PermissionInfo& info : list) {
view_->presenter_->OnSitePermissionChanged(info.type, info.setting);
+ }
CreateView();
}

Powered by Google App Engine
This is Rietveld 408576698