Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2946133002: Revert of mac: Roll hermetic toolchain to Xcode 8.3.2. (Closed)

Created:
3 years, 6 months ago by pdr.
Modified:
3 years, 6 months ago
Reviewers:
Dirk Pranke, erikchen
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mac: Roll hermetic toolchain to Xcode 8.3.2. (patchset #5 id:80001 of https://codereview.chromium.org/2941293003/ ) Reason for revert: Caused build failures: https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/19709 Original issue's description: > mac: Roll hermetic toolchain to Xcode 8.3.2. > > Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the > 10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK. > > BUG=624049 > > Review-Url: https://codereview.chromium.org/2941293003 > Cr-Original-Commit-Position: refs/heads/master@{#480685} > Committed: https://chromium.googlesource.com/chromium/src/+/abd9ba0ebfca0ce7a37c14593d55ebee56c4a55c > Review-Url: https://codereview.chromium.org/2941293003 > Cr-Commit-Position: refs/heads/master@{#480918} > Committed: https://chromium.googlesource.com/chromium/src/+/7f8f750fffcee0e256c228655e9d331f2dcb6f58 TBR=dpranke@chromium.org,erikchen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624049 Review-Url: https://codereview.chromium.org/2946133002 Cr-Commit-Position: refs/heads/master@{#480955} Committed: https://chromium.googlesource.com/chromium/src/+/00f82a9fe237df3f8c8d2db634df493b9699f83e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/mac_toolchain.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
pdr.
Created Revert of mac: Roll hermetic toolchain to Xcode 8.3.2.
3 years, 6 months ago (2017-06-20 21:19:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2946133002/1
3 years, 6 months ago (2017-06-20 21:20:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/00f82a9fe237df3f8c8d2db634df493b9699f83e
3 years, 6 months ago (2017-06-20 21:20:46 UTC) #6
Dirk Pranke
3 years, 6 months ago (2017-06-20 22:39:23 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698