|
|
Created:
3 years, 6 months ago by erikchen Modified:
3 years, 6 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews, mac-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Descriptionmac: Roll hermetic toolchain to Xcode 8.3.2.
Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the
10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK.
BUG=624049
Review-Url: https://codereview.chromium.org/2941293003
Cr-Original-Commit-Position: refs/heads/master@{#480685}
Committed: https://chromium.googlesource.com/chromium/src/+/abd9ba0ebfca0ce7a37c14593d55ebee56c4a55c
Review-Url: https://codereview.chromium.org/2941293003
Cr-Commit-Position: refs/heads/master@{#480918}
Committed: https://chromium.googlesource.com/chromium/src/+/7f8f750fffcee0e256c228655e9d331f2dcb6f58
Patch Set 1 #Patch Set 2 : debugging toolchain. #Patch Set 3 : roll new toolchain. #Patch Set 4 : rev toolchain again. #Patch Set 5 : rev toolchain again. #Messages
Total messages: 34 (22 generated)
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
erikchen@chromium.org changed reviewers: + dpranke@chromium.org
dpranke: Please review.
On 2017/06/19 17:37:37, erikchen wrote: > dpranke: Please review. Landing this means either you use the system xcode or you have to be on 10.12, right? When do you plan to land this? (lgtm otherwise).
On 2017/06/19 21:43:44, Dirk Pranke wrote: > On 2017/06/19 17:37:37, erikchen wrote: > > dpranke: Please review. > > Landing this means either you use the system xcode or you have to be on 10.12, > right? Yup. To the best of my knowledge, all hermetic bots are on 10.12 [except blink trybots, but those don't use hermetic]. > > When do you plan to land this? today > > (lgtm otherwise).
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 80001, "attempt_start_ts": 1497915913779740, "parent_rev": "1f020c554ddb46f220c211ced6e45c1b5a767e06", "commit_rev": "abd9ba0ebfca0ce7a37c14593d55ebee56c4a55c"}
Message was sent while issue was closed.
Description was changed from ========== mac: Roll hermetic toolchain to Xcode 8.3.2. Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the 10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK. BUG=624049 ========== to ========== mac: Roll hermetic toolchain to Xcode 8.3.2. Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the 10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK. BUG=624049 Review-Url: https://codereview.chromium.org/2941293003 Cr-Commit-Position: refs/heads/master@{#480685} Committed: https://chromium.googlesource.com/chromium/src/+/abd9ba0ebfca0ce7a37c14593d55... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/abd9ba0ebfca0ce7a37c14593d55...
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/2949743002/ by khushalsagar@chromium.org. The reason for reverting is: Speculative revert for https://bugs.chromium.org/p/chromium/issues/detail?id=734878.
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/2951663002/ by hayato@chromium.org. The reason for reverting is: gclient runhooks failing on 4 builders: WebKit Mac10.11 WebKit Mac10.11 (dbg) WebKit Mac10.11 (retina) WebKit Mac10.9 Findit (?) suspects CL abd9ba0 with 70% confidence. e.g. stdout: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit... npacking new toolchain. Accepting license. Executable requires at least macOS 10.12, but is being run on macOS 10.11.3, and so is exiting.Failed to download toolchain toolchain-8E2002-3.tgz. Exception Command '['sudo', '/usr/bin/xcodebuild', '-license', 'accept']' returned non-zero exit status 134 Exiting. Error: Command '/usr/bin/python src/build/mac_toolchain.py' returned non-zero exit status 1 in /b/c/b/mac_layout .
Message was sent while issue was closed.
Description was changed from ========== mac: Roll hermetic toolchain to Xcode 8.3.2. Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the 10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK. BUG=624049 Review-Url: https://codereview.chromium.org/2941293003 Cr-Commit-Position: refs/heads/master@{#480685} Committed: https://chromium.googlesource.com/chromium/src/+/abd9ba0ebfca0ce7a37c14593d55... ========== to ========== mac: Roll hermetic toolchain to Xcode 8.3.2. Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the 10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK. BUG=624049 Review-Url: https://codereview.chromium.org/2941293003 Cr-Commit-Position: refs/heads/master@{#480685} Committed: https://chromium.googlesource.com/chromium/src/+/abd9ba0ebfca0ce7a37c14593d55... ==========
Relanding. GPU bots re-imaged: https://bugs.chromium.org/p/chromium/issues/detail?id=734878 Hermetic toolchain disabled for WebKit bots: https://chromium-review.googlesource.com/c/540746/
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 80001, "attempt_start_ts": 1497988157168230, "parent_rev": "fd99b4a093a45f4252aca3a683333dcb0a7cb30f", "commit_rev": "7f8f750fffcee0e256c228655e9d331f2dcb6f58"}
Message was sent while issue was closed.
Description was changed from ========== mac: Roll hermetic toolchain to Xcode 8.3.2. Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the 10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK. BUG=624049 Review-Url: https://codereview.chromium.org/2941293003 Cr-Commit-Position: refs/heads/master@{#480685} Committed: https://chromium.googlesource.com/chromium/src/+/abd9ba0ebfca0ce7a37c14593d55... ========== to ========== mac: Roll hermetic toolchain to Xcode 8.3.2. Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the 10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK. BUG=624049 Review-Url: https://codereview.chromium.org/2941293003 Cr-Original-Commit-Position: refs/heads/master@{#480685} Committed: https://chromium.googlesource.com/chromium/src/+/abd9ba0ebfca0ce7a37c14593d55... Review-Url: https://codereview.chromium.org/2941293003 Cr-Commit-Position: refs/heads/master@{#480918} Committed: https://chromium.googlesource.com/chromium/src/+/7f8f750fffcee0e256c228655e9d... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/7f8f750fffcee0e256c228655e9d...
Message was sent while issue was closed.
On 2017/06/20 at 19:56:22, commit-bot wrote: > Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/7f8f750fffcee0e256c228655e9d... I think this patch caused this build failure: https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/19709 Deleting old toolchain. Unpacking new toolchain. Accepting license. dyld: Library not loaded: /usr/lib/libcompression.dylib Referenced from: /b/c/b/Mac10_10_Tests/src/build/mac_files/Xcode.app/Contents/SharedFrameworks/DTXConnectionServices.framework/Versions/A/DTXConnectionServices Reason: image not found Failed to download toolchain toolchain-8E2002-3.tgz. Exception Command '['sudo', '/usr/bin/xcodebuild', '-license', 'accept']' returned non-zero exit status 133 Exiting. Error: Command '/usr/bin/python src/build/mac_toolchain.py' returned non-zero exit status 1 in /b/c/b/Mac10_10_Tests Hook '/usr/bin/python src/build/mac_toolchain.py' took 54.11 secs step returned non-zero exit code: 2
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/2946133002/ by pdr@chromium.org. The reason for reverting is: Caused build failures: https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/19709. |