Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2941293003: mac: Roll hermetic toolchain to Xcode 8.3.2. (Closed)

Created:
3 years, 6 months ago by erikchen
Modified:
3 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Roll hermetic toolchain to Xcode 8.3.2. Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the 10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK. BUG=624049 Review-Url: https://codereview.chromium.org/2941293003 Cr-Original-Commit-Position: refs/heads/master@{#480685} Committed: https://chromium.googlesource.com/chromium/src/+/abd9ba0ebfca0ce7a37c14593d55ebee56c4a55c Review-Url: https://codereview.chromium.org/2941293003 Cr-Commit-Position: refs/heads/master@{#480918} Committed: https://chromium.googlesource.com/chromium/src/+/7f8f750fffcee0e256c228655e9d331f2dcb6f58

Patch Set 1 #

Patch Set 2 : debugging toolchain. #

Patch Set 3 : roll new toolchain. #

Patch Set 4 : rev toolchain again. #

Patch Set 5 : rev toolchain again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/mac_toolchain.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 34 (22 generated)
erikchen
dpranke: Please review.
3 years, 6 months ago (2017-06-19 17:37:37 UTC) #16
Dirk Pranke
On 2017/06/19 17:37:37, erikchen wrote: > dpranke: Please review. Landing this means either you use ...
3 years, 6 months ago (2017-06-19 21:43:44 UTC) #17
erikchen
On 2017/06/19 21:43:44, Dirk Pranke wrote: > On 2017/06/19 17:37:37, erikchen wrote: > > dpranke: ...
3 years, 6 months ago (2017-06-19 22:27:18 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941293003/80001
3 years, 6 months ago (2017-06-19 23:45:59 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/abd9ba0ebfca0ce7a37c14593d55ebee56c4a55c
3 years, 6 months ago (2017-06-20 01:50:14 UTC) #23
Khushal
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/2949743002/ by khushalsagar@chromium.org. ...
3 years, 6 months ago (2017-06-20 02:27:13 UTC) #24
hayato
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/2951663002/ by hayato@chromium.org. ...
3 years, 6 months ago (2017-06-20 03:37:17 UTC) #25
erikchen
Relanding. GPU bots re-imaged: https://bugs.chromium.org/p/chromium/issues/detail?id=734878 Hermetic toolchain disabled for WebKit bots: https://chromium-review.googlesource.com/c/540746/
3 years, 6 months ago (2017-06-20 19:48:32 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941293003/80001
3 years, 6 months ago (2017-06-20 19:50:01 UTC) #29
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/7f8f750fffcee0e256c228655e9d331f2dcb6f58
3 years, 6 months ago (2017-06-20 19:56:22 UTC) #32
pdr.
On 2017/06/20 at 19:56:22, commit-bot wrote: > Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/7f8f750fffcee0e256c228655e9d331f2dcb6f58 I think ...
3 years, 6 months ago (2017-06-20 21:10:34 UTC) #33
pdr.
3 years, 6 months ago (2017-06-20 21:19:44 UTC) #34
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2946133002/ by pdr@chromium.org.

The reason for reverting is: Caused build failures:
https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/19709.

Powered by Google App Engine
This is Rietveld 408576698