Add presubmit warning for JS formatting in chrome/browser/resources/

Add presubmit warning for JS formatting in chrome/browser/resources/

R=dpapad@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2945513003
Cr-Commit-Position: refs/heads/master@{#480938}
Committed: https://chromium.googlesource.com/chromium/src/+/dbc3edc12de1d6ad8e4e43aace717ed6ac3e5256

[Dan Beam, 2017-06-16 02:19:07]

Description was changed from

==========
Add presubmit to check JS formatting in chrome/browser/resources/

R=dpapad@chromium.org
BUG=567770
==========

to

==========
Add presubmit to check JS formatting in chrome/browser/resources/

R=dpapad@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-06-16 02:20:50]

Description was changed from

==========
Add presubmit to check JS formatting in chrome/browser/resources/

R=dpapad@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add presubmit warnings for JS formatting in chrome/browser/resources/

R=dpapad@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-06-16 02:21:34]

can we do this yet?

here's what the code could eventually look like:
https://codereview.chromium.org/2939273002/

[dpapad, 2017-06-16 02:35:54]

On 2017/06/16 at 02:21:34, dbeam wrote:
> can we do this yet?
> 
> here's what the code could eventually look like:
> https://codereview.chromium.org/2939273002/

Probably not just up to me, but I think the formatted code looks good for the
most part, so +1. Having said that, are you planning to land the other CL first,
before turning on the check?

[Dan Beam, 2017-06-16 02:40:06]

On 2017/06/16 02:35:54, dpapad wrote:
> On 2017/06/16 at 02:21:34, dbeam wrote:
> > can we do this yet?
> > 
> > here's what the code could eventually look like:
> > https://codereview.chromium.org/2939273002/
> 
> Probably not just up to me, but I think the formatted code looks good for the
> most part, so +1. Having said that, are you planning to land the other CL
first,
> before turning on the check?

nah, not in this case.  it touches a bunch of code that will probably get
deleted rather than edited soon.

also, it's just warning that doesn't block committing.

[Dan Beam, 2017-06-16 02:46:06]

Description was changed from

==========
Add presubmit warnings for JS formatting in chrome/browser/resources/

R=dpapad@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add presubmit warning for JS formatting in chrome/browser/resources/

R=dpapad@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-06-20 15:48:21]

LGTM

[Dan Beam, 2017-06-20 20:02:44]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-06-20 20:05:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 20:27:18]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497988964779640, "parent_rev":
"03453b1a18e489e6b43489fcca0ab26f6c4950cb", "commit_rev":
"f487c5c306f20b7c4652dcbf6477a47b4a6cc9f8"}

[commit-bot: I haz the power, 2017-06-20 20:27:43]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497988964779640, "parent_rev":
"83acda94e87839e1dde668f175291cfa44b860a1", "commit_rev":
"dbc3edc12de1d6ad8e4e43aace717ed6ac3e5256"}

[commit-bot: I haz the power, 2017-06-20 20:28:02]

Description was changed from

==========
Add presubmit warning for JS formatting in chrome/browser/resources/

R=dpapad@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add presubmit warning for JS formatting in chrome/browser/resources/

R=dpapad@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2945513003
Cr-Commit-Position: refs/heads/master@{#480938}
Committed:
https://chromium.googlesource.com/chromium/src/+/dbc3edc12de1d6ad8e4e43aace71...
==========

[commit-bot: I haz the power, 2017-06-20 20:28:04]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dbc3edc12de1d6ad8e4e43aace71...