Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2945513003: Add presubmit warning for JS formatting in chrome/browser/resources/ (Closed)

Created:
3 years, 6 months ago by Dan Beam
Modified:
3 years, 6 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-history_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, pam+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add presubmit warning for JS formatting in chrome/browser/resources/ R=dpapad@chromium.org BUG=567770 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2945513003 Cr-Commit-Position: refs/heads/master@{#480938} Committed: https://chromium.googlesource.com/chromium/src/+/dbc3edc12de1d6ad8e4e43aace717ed6ac3e5256

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M chrome/browser/resources/PRESUBMIT.py View 1 chunk +2 lines, -0 lines 0 comments Download
D chrome/browser/resources/md_bookmarks/PRESUBMIT.py View 1 chunk +0 lines, -7 lines 0 comments Download
D chrome/browser/resources/md_history/PRESUBMIT.py View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Dan Beam
can we do this yet? here's what the code could eventually look like: https://codereview.chromium.org/2939273002/
3 years, 6 months ago (2017-06-16 02:21:34 UTC) #3
dpapad
On 2017/06/16 at 02:21:34, dbeam wrote: > can we do this yet? > > here's ...
3 years, 6 months ago (2017-06-16 02:35:54 UTC) #4
Dan Beam
On 2017/06/16 02:35:54, dpapad wrote: > On 2017/06/16 at 02:21:34, dbeam wrote: > > can ...
3 years, 6 months ago (2017-06-16 02:40:06 UTC) #5
dpapad
LGTM
3 years, 6 months ago (2017-06-20 15:48:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2945513003/1
3 years, 6 months ago (2017-06-20 20:05:30 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 20:28:04 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dbc3edc12de1d6ad8e4e43aace71...

Powered by Google App Engine
This is Rietveld 408576698