chrome/browser/resources/PRESUBMIT.py - Issue 2945513003: Add presubmit warning for JS formatting in chrome/browser/resources/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/PRESUBMIT.py

Issue 2945513003: Add presubmit warning for JS formatting in chrome/browser/resources/ (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/PRESUBMIT.py

diff --git a/chrome/browser/resources/PRESUBMIT.py b/chrome/browser/resources/PRESUBMIT.py

index b523d6bec85b28be3066e1f7454f3ecc3880ec05..b8a8396d2417bc812b7a92261104c1e5d7c59825 100644

--- a/chrome/browser/resources/PRESUBMIT.py

+++ b/chrome/browser/resources/PRESUBMIT.py

@@ -126,6 +126,8 @@ def _CheckChangeOnUploadOrCommit(input_api, output_api):

if any(f for f in affected if f.LocalPath().endswith('vulcanize_gn.py')):

results += RunVulcanizeTests(input_api, output_api)

results += _CheckWebDevStyle(input_api, output_api)

+ results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api,

+ check_js=True)

return results

« no previous file with comments | « no previous file | chrome/browser/resources/md_bookmarks/PRESUBMIT.py » ('j') | no next file with comments »