Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2945483002: Reland of Moves mojo_js_integration_tests into blink. (Closed)

Created:
3 years, 6 months ago by alokp
Modified:
3 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, blink-reviews, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, Ken Rockot(use gerrit already), dcheng
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Moves mojo_js_integration_tests into blink. (patchset #1 id:1 of https://codereview.chromium.org/2939663002/ ) Reason for revert: mojo_bindings.js was not being included in test package, which is now fixed: crbug.com/733027 Original issue's description: > Revert of Moves mojo_js_integration_tests into blink. (patchset #1 id:1 of https://codereview.chromium.org/2920383004/ ) > > Reason for revert: > This CL seems to break webkit_unittests. > The error log is: > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/34695 > > The tests below were timed out: > JsToCppTest.BackPointer > JsToCppTest.BitFlip > JsToCppTest.Echo > JsToCppTest.Ping TBR=jbroman,dpranke,yzshen Review-Url: https://codereview.chromium.org/2945483002 Cr-Commit-Position: refs/heads/master@{#479913} Committed: https://chromium.googlesource.com/chromium/src/+/bae6a50045e233e6c5ab3c91292fbd6f1655bba8

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -994 lines) Patch
M mojo/edk/js/tests/BUILD.gn View 1 1 chunk +0 lines, -34 lines 0 comments Download
D mojo/edk/js/tests/js_to_cpp.mojom View 1 chunk +0 lines, -60 lines 0 comments Download
D mojo/edk/js/tests/js_to_cpp_tests.cc View 1 1 chunk +0 lines, -459 lines 0 comments Download
D mojo/edk/js/tests/js_to_cpp_tests.js View 1 chunk +0 lines, -215 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 2 chunks +0 lines, -12 lines 0 comments Download
M testing/buildbot/client.v8.chromium.json View 1 1 chunk +0 lines, -6 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/mojo/BUILD.gn View 1 2 chunks +37 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/mojo/tests/JsToCpp.mojom View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/mojo/tests/JsToCppTest.cpp View 1 2 14 chunks +143 lines, -166 lines 0 comments Download
A + third_party/WebKit/Source/core/mojo/tests/JsToCppTest.js View 1 10 chunks +27 lines, -37 lines 0 comments Download
A third_party/WebKit/Source/core/mojo/tests/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/UnitTestHelpers.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download
M tools/determinism/deterministic_build_whitelist.pyl View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
alokp
Created Reland of Moves mojo_js_integration_tests into blink.
3 years, 6 months ago (2017-06-15 21:20:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2945483002/1
3 years, 6 months ago (2017-06-15 21:25:43 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-06-15 21:25:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2945483002/1
3 years, 6 months ago (2017-06-15 21:29:28 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/318626)
3 years, 6 months ago (2017-06-15 21:51:10 UTC) #11
Dirk Pranke
rs- lgtm.
3 years, 6 months ago (2017-06-15 22:17:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2945483002/260001
3 years, 6 months ago (2017-06-15 22:35:15 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 01:59:15 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:260001) as
https://chromium.googlesource.com/chromium/src/+/bae6a50045e233e6c5ab3c91292f...

Powered by Google App Engine
This is Rietveld 408576698