Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1245)

Issue 2926143002: Revert of Moves mojo_js_integration_tests into blink. (Closed)

Created:
3 years, 6 months ago by jwd
Modified:
3 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, blink-reviews, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, Ken Rockot(use gerrit already), dcheng
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Moves mojo_js_integration_tests into blink. (patchset #11 id:190001 of https://codereview.chromium.org/2734783008/ ) Reason for revert: Seems related to webkit failures of the JsToCpp tests. E.x. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/34530. Original issue's description: > Moves mojo_js_integration_tests into blink. > > BUG=699569 > > Review-Url: https://codereview.chromium.org/2734783008 > Cr-Commit-Position: refs/heads/master@{#477549} > Committed: https://chromium.googlesource.com/chromium/src/+/dd57fa764813de09d159a232eeef1bb21b0ccc1e TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,alokp@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=699569 Review-Url: https://codereview.chromium.org/2926143002 Cr-Commit-Position: refs/heads/master@{#477653} Committed: https://chromium.googlesource.com/chromium/src/+/6536a56d25c245bd109e32ed49240bfc04f8890f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+792 lines, -749 lines) Patch
M mojo/edk/js/tests/BUILD.gn View 1 chunk +34 lines, -0 lines 0 comments Download
A mojo/edk/js/tests/js_to_cpp.mojom View 1 chunk +60 lines, -0 lines 0 comments Download
A mojo/edk/js/tests/js_to_cpp_tests.cc View 1 chunk +459 lines, -0 lines 0 comments Download
A mojo/edk/js/tests/js_to_cpp_tests.js View 1 chunk +215 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 2 chunks +12 lines, -0 lines 0 comments Download
M testing/buildbot/client.v8.chromium.json View 1 chunk +6 lines, -0 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/mojo/BUILD.gn View 2 chunks +0 lines, -37 lines 0 comments Download
D third_party/WebKit/Source/core/mojo/tests/JsToCpp.mojom View 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/WebKit/Source/core/mojo/tests/JsToCppTest.cpp View 1 chunk +0 lines, -435 lines 0 comments Download
D third_party/WebKit/Source/core/mojo/tests/JsToCppTest.js View 1 chunk +0 lines, -205 lines 0 comments Download
D third_party/WebKit/Source/core/mojo/tests/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/UnitTestHelpers.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/determinism/deterministic_build_whitelist.pyl View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jwd
Created Revert of Moves mojo_js_integration_tests into blink.
3 years, 6 months ago (2017-06-07 15:20:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2926143002/1
3 years, 6 months ago (2017-06-07 15:20:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6536a56d25c245bd109e32ed49240bfc04f8890f
3 years, 6 months ago (2017-06-07 15:20:55 UTC) #6
Dirk Pranke
lgtm
3 years, 6 months ago (2017-06-07 15:26:21 UTC) #7
alokp
3 years, 6 months ago (2017-06-07 17:48:49 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2920383004/ by alokp@chromium.org.

The reason for reverting is: Fixed failing tests..

Powered by Google App Engine
This is Rietveld 408576698