Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 2945383002: [Extensions] Fix FeatureProvider::GetChildren() (Closed)

Created:
3 years, 6 months ago by Devlin
Modified:
3 years, 6 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, jbroman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Fix FeatureProvider::GetChildren() FeatureProvider::GetChildren() was returning children that were explicitly set as no_parent. Fix this, and add a unit test. This also fixes PlatformAppBrowserTest.Restrictions with native bindings. BUG=653596 Review-Url: https://codereview.chromium.org/2945383002 Cr-Commit-Position: refs/heads/master@{#481373} Committed: https://chromium.googlesource.com/chromium/src/+/e0d1cc35ae732bd9dabc6393900c278dbb045245

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M extensions/common/features/feature_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/common/features/feature_provider_unittest.cc View 2 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Devlin
lazyboy@, mind taking a look? jbroman@, fyi.
3 years, 6 months ago (2017-06-22 00:03:30 UTC) #7
lazyboy
lgtm
3 years, 6 months ago (2017-06-22 00:16:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2945383002/1
3 years, 6 months ago (2017-06-22 00:22:48 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 00:27:42 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e0d1cc35ae732bd9dabc6393900c...

Powered by Google App Engine
This is Rietveld 408576698