Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: extensions/common/features/feature_provider.cc

Issue 2945383002: [Extensions] Fix FeatureProvider::GetChildren() (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/common/features/feature_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/features/feature_provider.cc
diff --git a/extensions/common/features/feature_provider.cc b/extensions/common/features/feature_provider.cc
index 99213c7ff531dceb553c0b7da8cd6feaebf28165..5e5b14519e50e55c49f0ed5c6fbbaf2da213a24b 100644
--- a/extensions/common/features/feature_provider.cc
+++ b/extensions/common/features/feature_provider.cc
@@ -164,7 +164,8 @@ std::vector<Feature*> FeatureProvider::GetChildren(
result.reserve(std::distance(first_child, after_children));
for (FeatureMap::const_iterator it = first_child; it != after_children;
++it) {
- result.push_back(it->second.get());
+ if (!it->second->no_parent())
+ result.push_back(it->second.get());
}
return result;
}
« no previous file with comments | « no previous file | extensions/common/features/feature_provider_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698