Unify IMEDriver and IMEServer.

Unify IMEDriver and IMEServer.

Each ui.mojom.InputMethod corresponds to one session. We don't need session_ids
to identify them.

Also removing the IMEDriver::CancelSession(). We can add it to
ui.mojom.InputMethod later if needed.

After these changes IMEDriver and IMEServer have the same interface, so unifying
them.

BUG=673358
Review-Url: https://codereview.chromium.org/2945283002
Cr-Commit-Position: refs/heads/master@{#481312}
Committed: https://chromium.googlesource.com/chromium/src/+/3ab7311328652527bb7d8b1b5e64eb1bf0c05872

[Hadi, 2017-06-21 14:10:00]

The CQ bit was checked by moshayedi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 14:10:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hadi, 2017-06-21 14:12:58]

moshayedi@chromium.org changed reviewers:
+ sky@chromium.org

[Hadi, 2017-06-21 14:12:58]

PTAL.

Now IMEDriver and IMEServer have exactly the same interface. Should I unify them
in a separate CL?

[Hadi, 2017-06-21 14:38:29]

The CQ bit was checked by moshayedi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 14:38:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hadi, 2017-06-21 14:39:39]

Description was changed from

==========
Don't use session_ids in IMEDriver::StartSession().

Each ui.mojom.InputMethod corresponds to one session. We don't need session_ids
to identify them.

Also removing the IMEDriver::CancelSession(). We can add it to
ui.mojom.InputMethod later if needed.

BUG=673358
==========

to

==========
Unify IMEDriver and IMEServer.

Each ui.mojom.InputMethod corresponds to one session. We don't need session_ids
to identify them.

Also removing the IMEDriver::CancelSession(). We can add it to
ui.mojom.InputMethod later if needed.

After these changes IMEDriver and IMEServer have the same interface, so unifying
them.

BUG=673358
==========

[Hadi, 2017-06-21 14:40:00]

Unified IMEDriver and IMEServer. PTAL.

[commit-bot: I haz the power, 2017-06-21 15:46:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 15:46:06]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Hadi, 2017-06-21 16:34:37]

The CQ bit was checked by moshayedi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 16:34:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 17:54:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 17:54:23]

Dry run: This issue passed the CQ dry run.

[sky, 2017-06-21 19:29:42]

LGTM

https://codereview.chromium.org/2945283002/diff/20001/services/ui/ime/ime_reg...
File services/ui/ime/ime_registrar_impl.cc (right):

https://codereview.chromium.org/2945283002/diff/20001/services/ui/ime/ime_reg...
services/ui/ime/ime_registrar_impl.cc:22:
ime_driver_bridge_->OnDriverChanged(std::move(driver));
Can you rename OnDriverChanged to SetDriver as that better indicates what the
function does.

[Hadi, 2017-06-21 19:54:37]

The CQ bit was checked by moshayedi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 19:55:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hadi, 2017-06-21 19:56:06]

moshayedi@chromium.org changed reviewers:
+ palmer@chromium.org

[Hadi, 2017-06-21 19:56:06]

palmer@ please review ime.mojom.

Thanks.

[palmer, 2017-06-21 20:19:43]

palmer@chromium.org changed reviewers:
+ sky@chromium.orgrs lgtm
- sky@chromium.org

[palmer, 2017-06-21 20:19:44]

RS LGTM

[Hadi, 2017-06-21 20:30:03]

The CQ bit was unchecked by moshayedi@chromium.org

[Hadi, 2017-06-21 20:30:08]

The CQ bit was checked by moshayedi@chromium.org

[Hadi, 2017-06-21 20:30:08]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2945283002/#ps40001
(title: "Addressed feedback.")

[commit-bot: I haz the power, 2017-06-21 20:30:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 21:40:44]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498077008309280,
"parent_rev": "2acd66ad843d8602e4f761f5be87f921df640482", "commit_rev":
"3ab7311328652527bb7d8b1b5e64eb1bf0c05872"}

[commit-bot: I haz the power, 2017-06-21 21:41:04]

Description was changed from

==========
Unify IMEDriver and IMEServer.

Each ui.mojom.InputMethod corresponds to one session. We don't need session_ids
to identify them.

Also removing the IMEDriver::CancelSession(). We can add it to
ui.mojom.InputMethod later if needed.

After these changes IMEDriver and IMEServer have the same interface, so unifying
them.

BUG=673358
==========

to

==========
Unify IMEDriver and IMEServer.

Each ui.mojom.InputMethod corresponds to one session. We don't need session_ids
to identify them.

Also removing the IMEDriver::CancelSession(). We can add it to
ui.mojom.InputMethod later if needed.

After these changes IMEDriver and IMEServer have the same interface, so unifying
them.

BUG=673358

Review-Url: https://codereview.chromium.org/2945283002
Cr-Commit-Position: refs/heads/master@{#481312}
Committed:
https://chromium.googlesource.com/chromium/src/+/3ab7311328652527bb7d8b1b5e64...
==========

[commit-bot: I haz the power, 2017-06-21 21:41:05]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3ab7311328652527bb7d8b1b5e64...