Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: services/ui/service.cc

Issue 2945283002: Unify IMEDriver and IMEServer. (Closed)
Patch Set: Addressed feedback. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « services/ui/service.h ('k') | ui/aura/mus/input_method_mus.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/ui/service.h" 5 #include "services/ui/service.h"
6 6
7 #include <set> 7 #include <set>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
11 #include "base/memory/ptr_util.h" 11 #include "base/memory/ptr_util.h"
12 #include "base/memory/weak_ptr.h" 12 #include "base/memory/weak_ptr.h"
13 #include "base/message_loop/message_loop.h" 13 #include "base/message_loop/message_loop.h"
14 #include "base/run_loop.h" 14 #include "base/run_loop.h"
15 #include "base/threading/platform_thread.h" 15 #include "base/threading/platform_thread.h"
16 #include "base/trace_event/trace_event.h" 16 #include "base/trace_event/trace_event.h"
17 #include "build/build_config.h" 17 #include "build/build_config.h"
18 #include "components/discardable_memory/service/discardable_shared_memory_manage r.h" 18 #include "components/discardable_memory/service/discardable_shared_memory_manage r.h"
19 #include "mojo/public/cpp/bindings/strong_binding.h" 19 #include "mojo/public/cpp/bindings/strong_binding.h"
20 #include "services/catalog/public/cpp/resource_loader.h" 20 #include "services/catalog/public/cpp/resource_loader.h"
21 #include "services/catalog/public/interfaces/constants.mojom.h" 21 #include "services/catalog/public/interfaces/constants.mojom.h"
22 #include "services/service_manager/public/c/main.h" 22 #include "services/service_manager/public/c/main.h"
23 #include "services/service_manager/public/cpp/connector.h" 23 #include "services/service_manager/public/cpp/connector.h"
24 #include "services/service_manager/public/cpp/service_context.h" 24 #include "services/service_manager/public/cpp/service_context.h"
25 #include "services/ui/clipboard/clipboard_impl.h" 25 #include "services/ui/clipboard/clipboard_impl.h"
26 #include "services/ui/common/switches.h" 26 #include "services/ui/common/switches.h"
27 #include "services/ui/display/screen_manager.h" 27 #include "services/ui/display/screen_manager.h"
28 #include "services/ui/ime/ime_driver_bridge.h"
28 #include "services/ui/ime/ime_registrar_impl.h" 29 #include "services/ui/ime/ime_registrar_impl.h"
29 #include "services/ui/ime/ime_server_impl.h"
30 #include "services/ui/ws/accessibility_manager.h" 30 #include "services/ui/ws/accessibility_manager.h"
31 #include "services/ui/ws/display_binding.h" 31 #include "services/ui/ws/display_binding.h"
32 #include "services/ui/ws/display_creation_config.h" 32 #include "services/ui/ws/display_creation_config.h"
33 #include "services/ui/ws/display_manager.h" 33 #include "services/ui/ws/display_manager.h"
34 #include "services/ui/ws/frame_sink_manager_client_binding.h" 34 #include "services/ui/ws/frame_sink_manager_client_binding.h"
35 #include "services/ui/ws/gpu_host.h" 35 #include "services/ui/ws/gpu_host.h"
36 #include "services/ui/ws/user_activity_monitor.h" 36 #include "services/ui/ws/user_activity_monitor.h"
37 #include "services/ui/ws/user_display_manager.h" 37 #include "services/ui/ws/user_display_manager.h"
38 #include "services/ui/ws/window_server.h" 38 #include "services/ui/ws/window_server.h"
39 #include "services/ui/ws/window_server_test_impl.h" 39 #include "services/ui/ws/window_server_test_impl.h"
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 std::unique_ptr<mojom::WindowTreeFactoryRequest> wtf_request; 84 std::unique_ptr<mojom::WindowTreeFactoryRequest> wtf_request;
85 std::unique_ptr<mojom::DisplayManagerRequest> dm_request; 85 std::unique_ptr<mojom::DisplayManagerRequest> dm_request;
86 }; 86 };
87 87
88 struct Service::UserState { 88 struct Service::UserState {
89 std::unique_ptr<clipboard::ClipboardImpl> clipboard; 89 std::unique_ptr<clipboard::ClipboardImpl> clipboard;
90 std::unique_ptr<ws::AccessibilityManager> accessibility; 90 std::unique_ptr<ws::AccessibilityManager> accessibility;
91 std::unique_ptr<ws::WindowTreeHostFactory> window_tree_host_factory; 91 std::unique_ptr<ws::WindowTreeHostFactory> window_tree_host_factory;
92 }; 92 };
93 93
94 Service::Service() 94 Service::Service() : test_config_(false), ime_registrar_(&ime_driver_) {}
95 : test_config_(false),
96 ime_registrar_(&ime_server_) {}
97 95
98 Service::~Service() { 96 Service::~Service() {
99 // Destroy |window_server_| first, since it depends on |event_source_|. 97 // Destroy |window_server_| first, since it depends on |event_source_|.
100 // WindowServer (or more correctly its Displays) may have state that needs to 98 // WindowServer (or more correctly its Displays) may have state that needs to
101 // be destroyed before GpuState as well. 99 // be destroyed before GpuState as well.
102 window_server_.reset(); 100 window_server_.reset();
103 101
104 #if defined(USE_OZONE) 102 #if defined(USE_OZONE)
105 #if defined(OS_CHROMEOS) 103 #if defined(OS_CHROMEOS)
106 // InputDeviceController uses ozone. 104 // InputDeviceController uses ozone.
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 214
217 window_server_.reset(new ws::WindowServer(this)); 215 window_server_.reset(new ws::WindowServer(this));
218 std::unique_ptr<ws::GpuHost> gpu_host = 216 std::unique_ptr<ws::GpuHost> gpu_host =
219 base::MakeUnique<ws::DefaultGpuHost>(window_server_.get()); 217 base::MakeUnique<ws::DefaultGpuHost>(window_server_.get());
220 std::unique_ptr<ws::FrameSinkManagerClientBinding> frame_sink_manager = 218 std::unique_ptr<ws::FrameSinkManagerClientBinding> frame_sink_manager =
221 base::MakeUnique<ws::FrameSinkManagerClientBinding>(window_server_.get(), 219 base::MakeUnique<ws::FrameSinkManagerClientBinding>(window_server_.get(),
222 gpu_host.get()); 220 gpu_host.get());
223 window_server_->SetGpuHost(std::move(gpu_host)); 221 window_server_->SetGpuHost(std::move(gpu_host));
224 window_server_->SetFrameSinkManager(std::move(frame_sink_manager)); 222 window_server_->SetFrameSinkManager(std::move(frame_sink_manager));
225 223
226 ime_server_.Init(context()->connector(), test_config_); 224 ime_driver_.Init(context()->connector(), test_config_);
227 225
228 discardable_shared_memory_manager_ = 226 discardable_shared_memory_manager_ =
229 base::MakeUnique<discardable_memory::DiscardableSharedMemoryManager>(); 227 base::MakeUnique<discardable_memory::DiscardableSharedMemoryManager>();
230 228
231 registry_.AddInterface<mojom::AccessibilityManager>(base::Bind( 229 registry_.AddInterface<mojom::AccessibilityManager>(base::Bind(
232 &Service::BindAccessibilityManagerRequest, base::Unretained(this))); 230 &Service::BindAccessibilityManagerRequest, base::Unretained(this)));
233 registry_.AddInterface<mojom::Clipboard>( 231 registry_.AddInterface<mojom::Clipboard>(
234 base::Bind(&Service::BindClipboardRequest, base::Unretained(this))); 232 base::Bind(&Service::BindClipboardRequest, base::Unretained(this)));
235 registry_.AddInterface<mojom::DisplayManager>( 233 registry_.AddInterface<mojom::DisplayManager>(
236 base::Bind(&Service::BindDisplayManagerRequest, base::Unretained(this))); 234 base::Bind(&Service::BindDisplayManagerRequest, base::Unretained(this)));
237 registry_.AddInterface<mojom::Gpu>( 235 registry_.AddInterface<mojom::Gpu>(
238 base::Bind(&Service::BindGpuRequest, base::Unretained(this))); 236 base::Bind(&Service::BindGpuRequest, base::Unretained(this)));
239 registry_.AddInterface<mojom::IMERegistrar>( 237 registry_.AddInterface<mojom::IMERegistrar>(
240 base::Bind(&Service::BindIMERegistrarRequest, base::Unretained(this))); 238 base::Bind(&Service::BindIMERegistrarRequest, base::Unretained(this)));
241 registry_.AddInterface<mojom::IMEServer>( 239 registry_.AddInterface<mojom::IMEDriver>(
242 base::Bind(&Service::BindIMEServerRequest, base::Unretained(this))); 240 base::Bind(&Service::BindIMEDriverRequest, base::Unretained(this)));
243 registry_.AddInterface<mojom::UserAccessManager>(base::Bind( 241 registry_.AddInterface<mojom::UserAccessManager>(base::Bind(
244 &Service::BindUserAccessManagerRequest, base::Unretained(this))); 242 &Service::BindUserAccessManagerRequest, base::Unretained(this)));
245 registry_.AddInterface<mojom::UserActivityMonitor>(base::Bind( 243 registry_.AddInterface<mojom::UserActivityMonitor>(base::Bind(
246 &Service::BindUserActivityMonitorRequest, base::Unretained(this))); 244 &Service::BindUserActivityMonitorRequest, base::Unretained(this)));
247 registry_.AddInterface<WindowTreeHostFactory>(base::Bind( 245 registry_.AddInterface<WindowTreeHostFactory>(base::Bind(
248 &Service::BindWindowTreeHostFactoryRequest, base::Unretained(this))); 246 &Service::BindWindowTreeHostFactoryRequest, base::Unretained(this)));
249 registry_.AddInterface<mojom::WindowManagerWindowTreeFactory>( 247 registry_.AddInterface<mojom::WindowManagerWindowTreeFactory>(
250 base::Bind(&Service::BindWindowManagerWindowTreeFactoryRequest, 248 base::Bind(&Service::BindWindowManagerWindowTreeFactoryRequest,
251 base::Unretained(this))); 249 base::Unretained(this)));
252 registry_.AddInterface<mojom::WindowTreeFactory>(base::Bind( 250 registry_.AddInterface<mojom::WindowTreeFactory>(base::Bind(
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
380 mojom::GpuRequest request) { 378 mojom::GpuRequest request) {
381 window_server_->gpu_host()->Add(std::move(request)); 379 window_server_->gpu_host()->Add(std::move(request));
382 } 380 }
383 381
384 void Service::BindIMERegistrarRequest( 382 void Service::BindIMERegistrarRequest(
385 const service_manager::BindSourceInfo& source_info, 383 const service_manager::BindSourceInfo& source_info,
386 mojom::IMERegistrarRequest request) { 384 mojom::IMERegistrarRequest request) {
387 ime_registrar_.AddBinding(std::move(request)); 385 ime_registrar_.AddBinding(std::move(request));
388 } 386 }
389 387
390 void Service::BindIMEServerRequest( 388 void Service::BindIMEDriverRequest(
391 const service_manager::BindSourceInfo& source_info, 389 const service_manager::BindSourceInfo& source_info,
392 mojom::IMEServerRequest request) { 390 mojom::IMEDriverRequest request) {
393 ime_server_.AddBinding(std::move(request)); 391 ime_driver_.AddBinding(std::move(request));
394 } 392 }
395 393
396 void Service::BindUserAccessManagerRequest( 394 void Service::BindUserAccessManagerRequest(
397 const service_manager::BindSourceInfo& source_info, 395 const service_manager::BindSourceInfo& source_info,
398 mojom::UserAccessManagerRequest request) { 396 mojom::UserAccessManagerRequest request) {
399 window_server_->user_id_tracker()->Bind(std::move(request)); 397 window_server_->user_id_tracker()->Bind(std::move(request));
400 } 398 }
401 399
402 void Service::BindUserActivityMonitorRequest( 400 void Service::BindUserActivityMonitorRequest(
403 const service_manager::BindSourceInfo& source_info, 401 const service_manager::BindSourceInfo& source_info,
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
458 mojom::WindowServerTestRequest request) { 456 mojom::WindowServerTestRequest request) {
459 if (!test_config_) 457 if (!test_config_)
460 return; 458 return;
461 mojo::MakeStrongBinding( 459 mojo::MakeStrongBinding(
462 base::MakeUnique<ws::WindowServerTestImpl>(window_server_.get()), 460 base::MakeUnique<ws::WindowServerTestImpl>(window_server_.get()),
463 std::move(request)); 461 std::move(request));
464 } 462 }
465 463
466 464
467 } // namespace ui 465 } // namespace ui
OLDNEW
« no previous file with comments | « services/ui/service.h ('k') | ui/aura/mus/input_method_mus.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698