Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2945083002: Remove memory cache from system URLRequestContext. (Closed)

Created:
3 years, 6 months ago by mmenke
Modified:
3 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove memory cache from system URLRequestContext. One was accidentally added in https://codereview.chromium.org/2939733002/. Previously, it had no cache. BUG=734619 Review-Url: https://codereview.chromium.org/2945083002 Cr-Commit-Position: refs/heads/master@{#480874} Committed: https://chromium.googlesource.com/chromium/src/+/333204ddfbcca26725a7a9d86023de3828f95701

Patch Set 1 #

Patch Set 2 : Remove change from another CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -13 lines) Patch
M chrome/browser/io_thread.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/io_thread_browsertest.cc View 6 chunks +43 lines, -13 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
mmenke
I had just assumed the system URLRequestContext had an in-memory cache before. I was wrong. ...
3 years, 6 months ago (2017-06-20 16:44:37 UTC) #6
Randy Smith (Not in Mondays)
Oops. LGTM.
3 years, 6 months ago (2017-06-20 17:01:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2945083002/20001
3 years, 6 months ago (2017-06-20 17:02:39 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/333204ddfbcca26725a7a9d86023de3828f95701
3 years, 6 months ago (2017-06-20 17:52:28 UTC) #13
mmenke
3 years, 6 months ago (2017-06-20 17:55:23 UTC) #14
Message was sent while issue was closed.
On 2017/06/20 17:52:28, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001) as
>
https://chromium.googlesource.com/chromium/src/+/333204ddfbcca26725a7a9d86023...

Oops.  commit message blamed the regression on the wrong CL.  :)

Powered by Google App Engine
This is Rietveld 408576698