Add some docs to URLRequestContextBuilder.

Add some docs to URLRequestContextBuilder.

BUG=none

Review-Url: https://codereview.chromium.org/2939733002
Cr-Commit-Position: refs/heads/master@{#479092}
Committed: https://chromium.googlesource.com/chromium/src/+/3a82cf12f68d4c72fa1bc68f6447247bd05ad569

[mmenke, 2017-06-13 16:24:13]

mmenke@chromium.org changed reviewers:
+ rdsmith@chromium.org

[mmenke, 2017-06-13 16:24:14]

WDYT?

[Randy Smith (Not in Mondays), 2017-06-13 16:28:01]

Beautiful; thank you!  LGTM.

https://codereview.chromium.org/2939733002/diff/2/net/url_request/url_request...
File net/url_request/url_request_context_builder.h (right):

https://codereview.chromium.org/2939733002/diff/2/net/url_request/url_request...
net/url_request/url_request_context_builder.h:59: // A URLRequestContextBuilder
creates a single URLRequestContext. Provides
nit, suggestion: "It provides methods .. which should be called before creating
..."

[mmenke, 2017-06-13 16:33:24]

Thanks!

https://codereview.chromium.org/2939733002/diff/2/net/url_request/url_request...
File net/url_request/url_request_context_builder.h (right):

https://codereview.chromium.org/2939733002/diff/2/net/url_request/url_request...
net/url_request/url_request_context_builder.h:59: // A URLRequestContextBuilder
creates a single URLRequestContext. Provides
On 2017/06/13 16:28:00, Randy Smith (Not in Mondays) wrote:
> nit, suggestion: "It provides methods .. which should be called before
creating
> ..."

Done.

[mmenke, 2017-06-13 16:33:49]

The CQ bit was checked by mmenke@chromium.org

[mmenke, 2017-06-13 16:33:49]

The patchset sent to the CQ was uploaded after l-g-t-m from rdsmith@chromium.org
Link to the patchset: https://codereview.chromium.org/2939733002/#ps30001
(title: "Response to comment")

[commit-bot: I haz the power, 2017-06-13 16:34:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 17:00:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 17:00:02]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mmenke, 2017-06-13 17:03:15]

On 2017/06/13 17:00:02, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
>   android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
>   android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
>   linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
>   linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Clearly the build was dependent on URLRequestContextBuilder having no docs.  :)

[mmenke, 2017-06-13 17:03:19]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2017-06-13 17:03:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Randy Smith (Not in Mondays), 2017-06-13 17:05:38]

On 2017/06/13 17:03:15, mmenke wrote:
> On 2017/06/13 17:00:02, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
> >
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
> >   android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
> >
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
> >   android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
> >
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
> >   linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
> >
>
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
> >   linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
> 
> Clearly the build was dependent on URLRequestContextBuilder having no docs. 
:)

I wouldn't touch that!  That's a load bearing lack-of-comment!

[commit-bot: I haz the power, 2017-06-13 17:07:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 17:07:10]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[mmenke, 2017-06-13 17:28:59]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2017-06-13 17:29:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 19:10:37]

CQ is committing da patch.

Bot data: {"patchset_id": 30001, "attempt_start_ts": 1497374939799270,
"parent_rev": "43a09226e00add3bc4e007bc2e171cfb3afe2df7", "commit_rev":
"3a82cf12f68d4c72fa1bc68f6447247bd05ad569"}

[commit-bot: I haz the power, 2017-06-13 19:10:52]

Description was changed from

==========
Add some docs to URLRequestContextBuilder.

BUG=none
==========

to

==========
Add some docs to URLRequestContextBuilder.

BUG=none

Review-Url: https://codereview.chromium.org/2939733002
Cr-Commit-Position: refs/heads/master@{#479092}
Committed:
https://chromium.googlesource.com/chromium/src/+/3a82cf12f68d4c72fa1bc68f6447...
==========

[commit-bot: I haz the power, 2017-06-13 19:10:54]

Committed patchset #3 (id:30001) as
https://chromium.googlesource.com/chromium/src/+/3a82cf12f68d4c72fa1bc68f6447...