Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2945063002: subType of null messing up WebStorm debugging (Closed)

Created:
3 years, 6 months ago by terry
Modified:
3 years, 6 months ago
Reviewers:
Jacob
CC:
reviews+dom_dartlang.org, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/heads/releases/2661_work
Visibility:
Public.

Description

subType of null messing up WebStorm debugging Also, removed the assignment of *result to NULL; (this happen during the 50 roll). Issue https://github.com/dart-lang/sdk/issues/29854 R=jacobr@google.com Committed: https://src.chromium.org/viewvc/chrome/branches/dart/dartium/src?view=rev&revision=aa424e93dc062d902d80db3e5e28c8b309f39403

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M third_party/WebKit/Source/bindings/core/dart/DartInjectedScript.cpp View 3 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
terry
3 years, 6 months ago (2017-06-20 15:33:21 UTC) #2
Jacob
lgtm
3 years, 6 months ago (2017-06-20 15:52:22 UTC) #3
terry
3 years, 6 months ago (2017-06-20 15:53:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aa424e93dc062d902d80db3e5e28c8b309f39403.

Powered by Google App Engine
This is Rietveld 408576698