Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: third_party/WebKit/Source/bindings/core/dart/DartInjectedScript.cpp

Issue 2945063002: subType of null messing up WebStorm debugging (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/dart/DartInjectedScript.cpp
diff --git a/third_party/WebKit/Source/bindings/core/dart/DartInjectedScript.cpp b/third_party/WebKit/Source/bindings/core/dart/DartInjectedScript.cpp
index 9f8d0e0b0c3efe13c09e5c91d077d20afc422491..e7f753b4b27a14286f7119444ab4ea2e407d4f65 100644
--- a/third_party/WebKit/Source/bindings/core/dart/DartInjectedScript.cpp
+++ b/third_party/WebKit/Source/bindings/core/dart/DartInjectedScript.cpp
@@ -450,8 +450,6 @@ void DartInjectedScript::packageObjectResult(Dart_Handle dartHandle, const Strin
{
ASSERT(Dart_IsInstance(dartHandle) || Dart_IsNull(dartHandle));
- *result = NULL;
-
// FIXMEDART: support returnByValue for Dart types that are expressible as JSON.
bool wasThrownVal = false;
Dart_Handle exception = 0;
@@ -511,7 +509,7 @@ void DartInjectedScript::packageObjectResult(Dart_Handle dartHandle, const Strin
isNode = true;
}
- const char* remoteType;
+ const char* remoteType = nullptr;
const char* remoteSubType = nullptr;
switch (value->type()) {
case protocol::Value::TypeBoolean:
@@ -533,7 +531,6 @@ void DartInjectedScript::packageObjectResult(Dart_Handle dartHandle, const Strin
case protocol::Value::TypeNull:
default:
remoteType = protocol::Runtime::RemoteObject::TypeEnum::Object;
- remoteSubType = protocol::Runtime::RemoteObject::SubtypeEnum::Null;
break;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698