Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2945023002: Introduce profile for lock screen apps (Closed)

Created:
3 years, 6 months ago by tbarzic
Modified:
3 years, 5 months ago
CC:
achuith+watch_chromium.org, alemate+watch_chromium.org, asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, davemoore+watch_chromium.org, extensions-reviews_chromium.org, fukino+watch_chromium.org, kalyank, Matt Giuca, oka+watch_chromium.org, oshima+watch_chromium.org, pam+watch_chromium.org, rginda+watch_chromium.org, sadrul, tfarina, yamaguchi+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce profile for lock screen apps Introduces the profile to be used to run lock screen apps, instead of sign-in profile. The profile behavior will be similar to sign-in profile, but using separate profile allows better isolation between apps running on login screen and apps running on lock screen (which have different set of app/extension APIs available), and make inference of lock screen extension context type more straight forward. Also, this will enable us to make lock screen app profile ephemeral. This also updates the way lock_screen_extension context is calculated, allows background pages in the profile for lock screen apps, and disables app autoupdates in the lock screen profile (since the app versions in the profile should correspond to app versions in the user profile). BUG=715781, 734698 Review-Url: https://codereview.chromium.org/2945023002 Cr-Commit-Position: refs/heads/master@{#483123} Committed: https://chromium.googlesource.com/chromium/src/+/d2a741e22ed01d0cf2868f4ddddeb984a417849d

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : rebase #

Patch Set 9 : . #

Total comments: 10

Patch Set 10 : . #

Patch Set 11 : . #

Patch Set 12 : . #

Total comments: 16

Patch Set 13 : . #

Patch Set 14 : . #

Patch Set 15 : typo in state_controller_unittests #

Patch Set 16 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -124 lines) Patch
M chrome/browser/chromeos/drive/file_system_util.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/mount_path_util.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/lock_screen_apps/state_controller.h View 1 2 3 4 5 6 7 8 9 6 chunks +24 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/lock_screen_apps/state_controller.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 6 chunks +56 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/lock_screen_apps/state_controller_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 20 chunks +52 lines, -38 lines 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager_factory.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/ownership/owner_settings_service_chromeos_factory.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/login_profile_policy_provider.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/user_network_configuration_updater_factory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +9 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/profiles/profile_helper.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/profiles/profile_helper.cc View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +24 lines, -2 lines 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/chrome_process_manager_delegate.cc View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 3 3 chunks +2 lines, -28 lines 0 comments Download
M chrome/browser/extensions/extension_system_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +13 lines, -5 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/policy/profile_policy_connector.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/policy/profile_policy_connector_factory.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 2 3 4 5 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/signin/easy_unlock_service_factory.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/supervised_user/child_accounts/child_account_service.cc View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_syncable_service_factory.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/base/testing_profile_manager.cc View 1 2 3 5 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/process_map_factory.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 50 (29 generated)
tbarzic
skuhne - for profiles achuith - chrome/browser/chromeos emaxx - policy rdevlin.cronin - extensions
3 years, 6 months ago (2017-06-21 03:26:35 UTC) #11
achuithb
On 2017/06/21 03:26:35, tbarzic wrote: > skuhne - for profiles > achuith - chrome/browser/chromeos > ...
3 years, 6 months ago (2017-06-21 09:23:34 UTC) #12
Devlin
On 2017/06/21 09:23:34, achuithb wrote: > On 2017/06/21 03:26:35, tbarzic wrote: > > skuhne - ...
3 years, 6 months ago (2017-06-21 13:17:07 UTC) #13
tbarzic
+xiyuan, who reviewed few other cls for the feature
3 years, 6 months ago (2017-06-22 18:48:27 UTC) #25
xiyuan
https://codereview.chromium.org/2945023002/diff/160001/chrome/browser/chromeos/lock_screen_apps/state_controller.cc File chrome/browser/chromeos/lock_screen_apps/state_controller.cc (right): https://codereview.chromium.org/2945023002/diff/160001/chrome/browser/chromeos/lock_screen_apps/state_controller.cc#newcode107 chrome/browser/chromeos/lock_screen_apps/state_controller.cc:107: "" /* suporevised_user_id */); nit: suporevised_user_id -> supervised_user_id https://codereview.chromium.org/2945023002/diff/160001/chrome/browser/chromeos/lock_screen_apps/state_controller.cc#newcode127 ...
3 years, 6 months ago (2017-06-22 20:15:25 UTC) #26
tbarzic
https://codereview.chromium.org/2945023002/diff/160001/chrome/browser/chromeos/lock_screen_apps/state_controller.cc File chrome/browser/chromeos/lock_screen_apps/state_controller.cc (right): https://codereview.chromium.org/2945023002/diff/160001/chrome/browser/chromeos/lock_screen_apps/state_controller.cc#newcode107 chrome/browser/chromeos/lock_screen_apps/state_controller.cc:107: "" /* suporevised_user_id */); On 2017/06/22 20:15:25, xiyuan wrote: ...
3 years, 6 months ago (2017-06-22 20:51:15 UTC) #27
xiyuan
lgtm https://codereview.chromium.org/2945023002/diff/160001/chrome/browser/chromeos/lock_screen_apps/state_controller.cc File chrome/browser/chromeos/lock_screen_apps/state_controller.cc (right): https://codereview.chromium.org/2945023002/diff/160001/chrome/browser/chromeos/lock_screen_apps/state_controller.cc#newcode127 chrome/browser/chromeos/lock_screen_apps/state_controller.cc:127: app_manager_->Initialize(primary_profile, lock_screen_profile); On 2017/06/22 20:51:15, tbarzic wrote: > ...
3 years, 6 months ago (2017-06-22 20:52:59 UTC) #28
Mr4D (OOO till 08-26)
I think that the profile changes should be fine. lgtm However: Adding anthonyvd as well ...
3 years, 6 months ago (2017-06-22 21:28:09 UTC) #30
tbarzic
https://codereview.chromium.org/2945023002/diff/160001/chrome/browser/chromeos/profiles/profile_helper.h File chrome/browser/chromeos/profiles/profile_helper.h (right): https://codereview.chromium.org/2945023002/diff/160001/chrome/browser/chromeos/profiles/profile_helper.h#newcode118 chrome/browser/chromeos/profiles/profile_helper.h:118: // for launching platform apps that can display windowa ...
3 years, 6 months ago (2017-06-22 22:01:36 UTC) #31
anthonyvd
c/b/profiles/ lgtm, although it's all ChromeOS-specific and I've never worked on ChromeOS :)
3 years, 6 months ago (2017-06-23 14:54:22 UTC) #32
emaxx
LGTM % nits for policy. Question: shouldn't the accessibility prefs be passed from the user ...
3 years, 6 months ago (2017-06-23 16:16:30 UTC) #33
tbarzic
Passing accessibility prefs to lock screen app profile will have no real effect - a11y ...
3 years, 6 months ago (2017-06-23 17:18:41 UTC) #34
tbarzic
adding few missing owners: mpearson - chrome/browser/metrics bauerb - chrome/browser/supervised_user sky - chrome/browser/ui/ash && chrome/test/base
3 years, 5 months ago (2017-06-28 00:05:29 UTC) #36
sky
LGTM
3 years, 5 months ago (2017-06-28 00:26:33 UTC) #37
Devlin
extensions lgtm
3 years, 5 months ago (2017-06-28 00:31:03 UTC) #38
Mark P
chrome/browser/metrics/ lgtm
3 years, 5 months ago (2017-06-28 16:49:20 UTC) #39
Bernhard Bauer
lgtm
3 years, 5 months ago (2017-06-28 16:58:05 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2945023002/300001
3 years, 5 months ago (2017-06-28 18:26:51 UTC) #43
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/459740)
3 years, 5 months ago (2017-06-28 19:06:10 UTC) #45
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2945023002/300001
3 years, 5 months ago (2017-06-28 19:20:53 UTC) #47
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 20:38:16 UTC) #50
Message was sent while issue was closed.
Committed patchset #16 (id:300001) as
https://chromium.googlesource.com/chromium/src/+/d2a741e22ed01d0cf2868f4dddde...

Powered by Google App Engine
This is Rietveld 408576698