Introduce profile for lock screen apps

chrome/browser/policy/profile_policy_connector_factory.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/profile_policy_connector_factory.h"
 
 #include <utility>
 
 #include "base/logging.h"
 #include "base/memory/singleton.h"
@@ skipping 89 matching lines @@
 
   const user_manager::User* user = nullptr;
   SchemaRegistry* schema_registry =
       SchemaRegistryServiceFactory::GetForContext(context)->registry();
 
   ConfigurationPolicyProvider* policy_provider = nullptr;
   const CloudPolicyStore* policy_store = nullptr;
 
 #if defined(OS_CHROMEOS)
   Profile* const profile = Profile::FromBrowserContext(context);
-  if (!chromeos::ProfileHelper::IsSigninProfile(profile)) {
+  if (!chromeos::ProfileHelper::IsSigninProfile(profile) &&
+      !chromeos::ProfileHelper::IsLockScreenAppProfile(profile)) {
     user = chromeos::ProfileHelper::Get()->GetUserByProfile(profile);
     CHECK(user);
   }
 
   CloudPolicyManager* user_cloud_policy_manager =
       UserPolicyManagerFactoryChromeOS::GetCloudPolicyManagerForProfile(
           profile);
   ActiveDirectoryPolicyManager* active_directory_manager =
       UserPolicyManagerFactoryChromeOS::
           GetActiveDirectoryPolicyManagerForProfile(profile);
@@ skipping 10 matching lines @@
   if (user_cloud_policy_manager) {
     policy_provider = user_cloud_policy_manager;
     policy_store = user_cloud_policy_manager->core()->store();
   }
 #endif  // defined(OS_CHROMEOS)
 
   std::unique_ptr<ProfilePolicyConnector> connector(
       new ProfilePolicyConnector());
 
   if (test_providers_.empty()) {
     connector->Init(user, schema_registry, policy_provider, policy_store,

[emaxx, 2017/06/23 16:16:30]

nit: Please update the comments to mention the new profile in places that used
to refer to only sign-in profile:
* ProfilePolicyConnector:
https://cs.chromium.org/chromium/src/chrome/browser/policy/profile_policy_con...,
https://cs.chromium.org/chromium/src/chrome/browser/policy/profile_policy_con...,
https://cs.chromium.org/chromium/src/chrome/browser/policy/profile_policy_con...
* LoginProfilePolicyProvider:
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/policy/login_pro...

[emaxx, 2017/06/23 16:16:30]

A DCHECK will be hit there if an incognito profile derived from the lock screen
app profile will be passed here. But you don't plan to use the incognito
profile, is that correct?

[tbarzic, 2017/06/23 17:18:40]

Done.

[tbarzic, 2017/06/23 17:18:40]

Yes, that's correct.

(And CreateForBrowserContextInternal doesn't seem to get called for off the
record profiles)

                     force_immediate_load);
   } else {
     PolicyServiceImpl::Providers providers;
     providers.push_back(test_providers_.front());
     test_providers_.pop_front();
     std::unique_ptr<PolicyService> service(new PolicyServiceImpl(providers));
     connector->InitForTesting(std::move(service));
   }
 
   connectors_[context] = connector.get();
@@ skipping 22 matching lines @@
 
 bool ProfilePolicyConnectorFactory::HasTestingFactory(
     content::BrowserContext* context) {
   return false;
 }
 
 void ProfilePolicyConnectorFactory::CreateServiceNow(
     content::BrowserContext* context) {}
 
 }  // namespace policy