Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2944773002: Revert of Test changing default Windows compiler to VS2017 (Closed)

Created:
3 years, 6 months ago by brucedawson
Modified:
3 years, 6 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Test changing default Windows compiler to VS2017 (patchset #1 id:1 of https://codereview.chromium.org/2862723004/ ) Reason for revert: Build 61.0.3134.0 uses VS 2017 and that will be sufficient to let us look for performance regressions and crashes, so I am reverting. Original issue's description: > Test changing default Windows compiler to VS2017 > > Doing another VS2017 test over the week end now to see if a recently > discovered code-gen bug has been fixed. The VS 2017 package now uses > VS 2017 Update 3 Preview 2 (was Preview 1 last time). At least one > code-gen bug was fixed by Preview 2 but this bug may be a new one. > > This CL is currently purely for testing purposes and will be reverted by > the end of the week end. > > R=scottmg@chromium.org > BUG=683729, 727671 > > Review-Url: https://codereview.chromium.org/2862723004 > Cr-Commit-Position: refs/heads/master@{#480264} > Committed: https://chromium.googlesource.com/chromium/src/+/f278a33ca6aff0723f13942bbb47b3753bea543d TBR=scottmg@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=683729, 727671 Review-Url: https://codereview.chromium.org/2944773002 Cr-Commit-Position: refs/heads/master@{#480315} Committed: https://chromium.googlesource.com/chromium/src/+/eb339abb6c31f0f6a02d7b7038031ced69898eea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/vs_toolchain.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
brucedawson
Created Revert of Test changing default Windows compiler to VS2017
3 years, 6 months ago (2017-06-18 18:26:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2944773002/1
3 years, 6 months ago (2017-06-18 18:26:42 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-18 23:26:19 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eb339abb6c31f0f6a02d7b703803...

Powered by Google App Engine
This is Rietveld 408576698