Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2862723004:
Test changing default Windows compiler to VS2017 (Closed)
|
Created:
3 years, 7 months ago by brucedawson Modified:
3 years, 6 months ago Reviewers:
scottmg CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionTest changing default Windows compiler to VS2017
Doing another VS2017 test over the week end now to see if a recently
discovered code-gen bug has been fixed. The VS 2017 package now uses
VS 2017 Update 3 Preview 2 (was Preview 1 last time). At least one
code-gen bug was fixed by Preview 2 but this bug may be a new one.
This CL is currently purely for testing purposes and will be reverted by
the end of the week end.
R=scottmg@chromium.org
BUG=683729, 727671
Review-Url: https://codereview.chromium.org/2862723004
Cr-Commit-Position: refs/heads/master@{#480264}
Committed: https://chromium.googlesource.com/chromium/src/+/f278a33ca6aff0723f13942bbb47b3753bea543d
Patch Set 1 #
Messages
Total messages: 29 (25 generated)
The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Test changing to VS 2017 BUG=683729 ========== to ========== Test changing default Windows compiler to VS2017 Doing another VS2017 test over the week end now to see if a recently discovered code-gen bug has been fixed. The VS 2017 package now uses VS 2017 Update 3 Preview 2 (was Preview 1 last time). At least one code-gen bug was fixed by Preview 2 but this bug may be a new one. This CL is currently purely for testing purposes and will be reverted by the end of the week end. R=scottmg@chromium.org BUG=683729,727671 ==========
brucedawson@chromium.org changed reviewers: + scottmg@chromium.org
The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by brucedawson@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1497663302632140, "parent_rev":
"ce3f7dbfedb4040c7077644654f174b92169c3ec", "commit_rev":
"f278a33ca6aff0723f13942bbb47b3753bea543d"}
Message was sent while issue was closed.
Description was changed from ========== Test changing default Windows compiler to VS2017 Doing another VS2017 test over the week end now to see if a recently discovered code-gen bug has been fixed. The VS 2017 package now uses VS 2017 Update 3 Preview 2 (was Preview 1 last time). At least one code-gen bug was fixed by Preview 2 but this bug may be a new one. This CL is currently purely for testing purposes and will be reverted by the end of the week end. R=scottmg@chromium.org BUG=683729,727671 ========== to ========== Test changing default Windows compiler to VS2017 Doing another VS2017 test over the week end now to see if a recently discovered code-gen bug has been fixed. The VS 2017 package now uses VS 2017 Update 3 Preview 2 (was Preview 1 last time). At least one code-gen bug was fixed by Preview 2 but this bug may be a new one. This CL is currently purely for testing purposes and will be reverted by the end of the week end. R=scottmg@chromium.org BUG=683729,727671 Review-Url: https://codereview.chromium.org/2862723004 Cr-Commit-Position: refs/heads/master@{#480264} Committed: https://chromium.googlesource.com/chromium/src/+/f278a33ca6aff0723f13942bbb47... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f278a33ca6aff0723f13942bbb47...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2944773002/ by brucedawson@chromium.org. The reason for reverting is: Build 61.0.3134.0 uses VS 2017 and that will be sufficient to let us look for performance regressions and crashes, so I am reverting.. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
