Allow extension crash notifications to replace each other.

Allow extension crash notifications to replace each other.

Previously they did not set an origin or replace_id, causing updates
to be turned into adds in the notification UI manager, where it would
DCHECK because the id matched that of an existing notification.

This patch adds a replace_id and origin so that updates can happen
smoothly.

BUG=360591
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272006

[Andrew T Wilson (Slow), 2014-05-19 14:02:27]

LGTM with a few nits

https://codereview.chromium.org/294473002/diff/20001/chrome/browser/backgroun...
File chrome/browser/background/background_contents_service.cc (right):

https://codereview.chromium.org/294473002/diff/20001/chrome/browser/backgroun...
chrome/browser/background/background_contents_service.cc:184:
base::UTF8ToUTF16(delegate->id()),
Maybe some inline comment that this is the replace_id? I just get nervous when
we have several function params, all of string type, with nothing saying what
each one is.

https://codereview.chromium.org/294473002/diff/20001/chrome/browser/backgroun...
File chrome/browser/background/background_contents_service_unittest.cc (right):

https://codereview.chromium.org/294473002/diff/20001/chrome/browser/backgroun...
chrome/browser/background/background_contents_service_unittest.cc:147: virtual
void OnNotificationUpdated(
blank line above this

https://codereview.chromium.org/294473002/diff/20001/chrome/browser/backgroun...
chrome/browser/background/background_contents_service_unittest.cc:379:
CreateCrashNotification(extension);
Do we need to check that there's only one extension being shown?

[dewittj, 2014-05-20 18:18:22]

https://codereview.chromium.org/294473002/diff/20001/chrome/browser/backgroun...
File chrome/browser/background/background_contents_service.cc (right):

https://codereview.chromium.org/294473002/diff/20001/chrome/browser/backgroun...
chrome/browser/background/background_contents_service.cc:184:
base::UTF8ToUTF16(delegate->id()),
On 2014/05/19 14:02:27, Andrew T Wilson wrote:
> Maybe some inline comment that this is the replace_id? I just get nervous when
> we have several function params, all of string type, with nothing saying what
> each one is.

Done.

https://codereview.chromium.org/294473002/diff/20001/chrome/browser/backgroun...
File chrome/browser/background/background_contents_service_unittest.cc (right):

https://codereview.chromium.org/294473002/diff/20001/chrome/browser/backgroun...
chrome/browser/background/background_contents_service_unittest.cc:147: virtual
void OnNotificationUpdated(
On 2014/05/19 14:02:27, Andrew T Wilson wrote:
> blank line above this

Done.

https://codereview.chromium.org/294473002/diff/20001/chrome/browser/backgroun...
chrome/browser/background/background_contents_service_unittest.cc:379:
CreateCrashNotification(extension);
On 2014/05/19 14:02:27, Andrew T Wilson wrote:
> Do we need to check that there's only one extension being shown?

Done.

[dewittj, 2014-05-20 21:22:56]

The CQ bit was checked by dewittj@chromium.org

[commit-bot: I haz the power, 2014-05-20 21:24:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dewittj@chromium.org/294473002/40001

[commit-bot: I haz the power, 2014-05-20 22:27:50]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-20 23:31:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-20 23:31:01]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[dewittj, 2014-05-21 21:28:21]

The CQ bit was checked by dewittj@chromium.org

[commit-bot: I haz the power, 2014-05-21 21:29:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dewittj@chromium.org/294473002/40001

[commit-bot: I haz the power, 2014-05-21 23:14:09]

Change committed as 272006