Allow extension crash notifications to replace each other.

chrome/browser/background/background_contents_service_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 113 matching lines @@
 class NotificationWaiter : public message_center::MessageCenterObserver {
  public:
   explicit NotificationWaiter(const std::string& target_id)
       : target_id_(target_id) {}
   virtual ~NotificationWaiter() {}
 
   void WaitForNotificationAdded() {
     DCHECK(!run_loop_.running());
     message_center::MessageCenter* message_center =
         message_center::MessageCenter::Get();
-    if (message_center->HasNotification(target_id_))
-      return;
 
     message_center->AddObserver(this);
     run_loop_.Run();
     message_center->RemoveObserver(this);
   }
 
  private:
   // message_center::MessageCenterObserver overrides:
   virtual void OnNotificationAdded(
       const std::string& notification_id) OVERRIDE {
     if (notification_id == target_id_)
       run_loop_.Quit();
   }
+  virtual void OnNotificationUpdated(

[Andrew T Wilson (Slow), 2014/05/19 14:02:27]

blank line above this

[dewittj, 2014/05/20 18:18:22]

Done.

+      const std::string& notification_id) OVERRIDE {
+    if (notification_id == target_id_)
+      run_loop_.Quit();
+  }
 
   std::string target_id_;
   base::RunLoop run_loop_;
 
   DISALLOW_COPY_AND_ASSIGN(NotificationWaiter);
 };
 
 class BackgroundContentsServiceNotificationTest
     : public BrowserWithTestWindowTest {
  public:
@@ skipping 200 matching lines @@
 TEST_F(BackgroundContentsServiceNotificationTest, TestShowBalloonNoIcon) {
   // Extension manifest file with no 'icon' field.
   scoped_refptr<extensions::Extension> extension =
       extension_test_util::LoadManifest("app", "manifest.json");
   ASSERT_TRUE(extension.get());
   ASSERT_FALSE(extension->GetManifestData("icons"));
 
   const Notification* notification = CreateCrashNotification(extension);
   EXPECT_FALSE(notification->icon().IsEmpty());
 }
+
+TEST_F(BackgroundContentsServiceNotificationTest, TestShowTwoBalloons) {
+  TestingProfile profile;
+  scoped_refptr<extensions::Extension> extension =
+      extension_test_util::LoadManifest("app", "manifest.json");
+  ASSERT_TRUE(extension.get());
+  CreateCrashNotification(extension);
+  CreateCrashNotification(extension);

[Andrew T Wilson (Slow), 2014/05/19 14:02:27]

Do we need to check that there's only one extension being shown?

[dewittj, 2014/05/20 18:18:22]

Done.

+}
 #endif