Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Unified Diff: chrome/browser/background/background_contents_service.cc

Issue 294473002: Allow extension crash notifications to replace each other. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address nits Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/background/background_contents_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/background/background_contents_service.cc
diff --git a/chrome/browser/background/background_contents_service.cc b/chrome/browser/background/background_contents_service.cc
index 0d21871a71498f18d871daa1ae3a1cb05b63b93f..45e84c1716d72c2f695b5e48d3ef8372170d20f3 100644
--- a/chrome/browser/background/background_contents_service.cc
+++ b/chrome/browser/background/background_contents_service.cc
@@ -177,11 +177,11 @@ void NotificationImageReady(
// TODO(mukai, dewittj): remove this and switch to message center
// notifications.
DesktopNotificationService::AddIconNotification(
- GURL() /* empty origin */,
- base::string16(),
+ GURL("chrome://extension-crash"), // Origin URL.
+ base::string16(), // Title of notification.
message,
notification_icon,
- base::string16(),
+ base::UTF8ToUTF16(delegate->id()), // Replace ID.
delegate.get(),
profile);
}
« no previous file with comments | « no previous file | chrome/browser/background/background_contents_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698