Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2944703003: Fix up Linux packaging deps after r480167. (Closed)

Created:
3 years, 6 months ago by Lei Zhang
Modified:
3 years, 6 months ago
Reviewers:
Tom Anderson, pcc1
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, Michael Moss, wfh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix up Linux packaging deps after r480167. BUG=730757, 732440 TBR=thomasanderson@chromium.org NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2944703003 Cr-Commit-Position: refs/heads/master@{#480193} Committed: https://chromium.googlesource.com/chromium/src/+/a7494e43f3d82f3e6232d8b7d26aa175f617aead

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/installer/linux/debian/expected_deps_x64_jessie View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Lei Zhang
TBR Just copying what https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle_Chrome_Linux_x64%2F18447%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout says the actual output is.
3 years, 6 months ago (2017-06-16 22:04:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2944703003/1
3 years, 6 months ago (2017-06-16 22:04:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a7494e43f3d82f3e6232d8b7d26aa175f617aead
3 years, 6 months ago (2017-06-16 22:10:41 UTC) #6
Lei Zhang
BTW, the libdbus change is probably from https://codereview.chromium.org/2939373002
3 years, 6 months ago (2017-06-16 22:42:44 UTC) #8
Tom Anderson
Hm.. In my local build, there wasn't a dbus change (and my CL doesn't add ...
3 years, 6 months ago (2017-06-16 22:44:47 UTC) #9
Tom Anderson
On 2017/06/16 22:44:47, Tom Anderson wrote: > Hm.. In my local build, there wasn't a ...
3 years, 6 months ago (2017-06-16 22:47:24 UTC) #10
Lei Zhang
3 years, 6 months ago (2017-06-16 22:48:53 UTC) #11
Message was sent while issue was closed.
On 2017/06/16 22:47:24, Tom Anderson wrote:
> On 2017/06/16 22:44:47, Tom Anderson wrote:
> > Hm.. In my local build, there wasn't a dbus change (and my CL doesn't add
any
> > dbus symbols).  Was that change caused by something else?
> 
> ah, you beat me to it!

pcc mentioned it on IRC.

Powered by Google App Engine
This is Rietveld 408576698