Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2944453002: VR: Stop sending mouse moves while mouse is down to content window. (Closed)

Created:
3 years, 6 months ago by mthiesse
Modified:
3 years, 6 months ago
Reviewers:
Ian Vollick
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

VR: Stop sending mouse moves while mouse is down to content window. The VR controller is way too noisy/sensitive and triggers drag events when you're trying to click links. As a temporary workaround, stop sending move events to the content window when the 'mouse' is down. BUG=732917 Review-Url: https://codereview.chromium.org/2944453002 Cr-Commit-Position: refs/heads/master@{#479720} Committed: https://chromium.googlesource.com/chromium/src/+/2acdcced51403c0b6d0ed515f0e86d432a901839

Patch Set 1 #

Total comments: 1

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/android/vr_shell/vr_shell_gl.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mthiesse
PTAL
3 years, 6 months ago (2017-06-15 15:09:04 UTC) #2
Ian Vollick
lgtm. https://codereview.chromium.org/2944453002/diff/1/chrome/browser/android/vr_shell/vr_shell_gl.cc File chrome/browser/android/vr_shell/vr_shell_gl.cc (right): https://codereview.chromium.org/2944453002/diff/1/chrome/browser/android/vr_shell/vr_shell_gl.cc#newcode747 chrome/browser/android/vr_shell/vr_shell_gl.cc:747: // TODO(mthiesse, vollick): Content is currently way to ...
3 years, 6 months ago (2017-06-15 15:09:57 UTC) #3
mthiesse
3 years, 6 months ago (2017-06-15 15:14:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2944453002/20001
3 years, 6 months ago (2017-06-15 15:14:44 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 15:56:51 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2acdcced51403c0b6d0ed515f0e8...

Powered by Google App Engine
This is Rietveld 408576698