Do not pass by non-const reference in page_info.cc

Do not pass by non-const reference in page_info.cc

Review-Url: https://codereview.chromium.org/2944253002
Cr-Commit-Position: refs/heads/master@{#480943}
Committed: https://chromium.googlesource.com/chromium/src/+/4427f13b94cffc0223913b4a0dff4af24f944887

[Lei Zhang, 2017-06-20 01:30:23]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 01:30:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 03:25:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 03:25:23]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2017-06-20 18:20:15]

thestig@chromium.org changed reviewers:
+ elawrence@chromium.org

[elawrence, 2017-06-20 19:33:18]

On 2017/06/20 18:20:15, Lei Zhang wrote:

Non-OWNER LGTM, thanks for the cleanup!

Curious: Is there any reason not to declare the pointer itself const, e.g.

void ReportAnyInsecureContent(const security_state::SecurityInfo& security_info,
                              PageInfo::SiteConnectionStatus* const
connection_status,
                              base::string16* const connection_details) {

?

[Lei Zhang, 2017-06-20 20:24:52]

On 2017/06/20 19:33:18, elawrence wrote:
> On 2017/06/20 18:20:15, Lei Zhang wrote:
> 
> Non-OWNER LGTM, thanks for the cleanup!
> 
> Curious: Is there any reason not to declare the pointer itself const, e.g.
> 
> void ReportAnyInsecureContent(const security_state::SecurityInfo&
security_info,
>                               PageInfo::SiteConnectionStatus* const
> connection_status,
>                               base::string16* const connection_details) {
> 
> ?

Probably for the same reason we don't bother passing in a "const int" - it
doesn't matter as much what the function does with the (pointer) value.

[Lei Zhang, 2017-06-20 20:24:58]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2017-06-20 20:25:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 20:42:52]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497990298066410, "parent_rev":
"8b0b2a16a1e141102620e7d173271197cd6b7f3d", "commit_rev":
"eb79667a0305bdd8aa7d75a35b97ad131a0568e9"}

[commit-bot: I haz the power, 2017-06-20 20:43:09]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497990298066410, "parent_rev":
"b36fb29ec88440b9b85765b2b653a52c56b20e6f", "commit_rev":
"4427f13b94cffc0223913b4a0dff4af24f944887"}

[commit-bot: I haz the power, 2017-06-20 20:43:22]

Description was changed from

==========
Do not pass by non-const reference in page_info.cc
==========

to

==========
Do not pass by non-const reference in page_info.cc

Review-Url: https://codereview.chromium.org/2944253002
Cr-Commit-Position: refs/heads/master@{#480943}
Committed:
https://chromium.googlesource.com/chromium/src/+/4427f13b94cffc0223913b4a0dff...
==========

[commit-bot: I haz the power, 2017-06-20 20:43:24]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4427f13b94cffc0223913b4a0dff...