Do not pass by non-const reference in page_info.cc

chrome/browser/ui/page_info/page_info.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/page_info/page_info.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <string>
@@ skipping 146 matching lines @@
       break;
     case security_state::CONTENT_STATUS_UNKNOWN:
     case security_state::CONTENT_STATUS_NONE:
       break;
   }
 }
 
 // If the |security_info| indicates that mixed content or certificate errors
 // were present, update |connection_status| and |connection_details|.
 void ReportAnyInsecureContent(const security_state::SecurityInfo& security_info,
-                              PageInfo::SiteConnectionStatus& connection_status,
-                              base::string16& connection_details) {
+                              PageInfo::SiteConnectionStatus* connection_status,
+                              base::string16* connection_details) {
   bool displayed_insecure_content = false;
   bool ran_insecure_content = false;
   CheckContentStatus(security_info.mixed_content_status,
                      &displayed_insecure_content, &ran_insecure_content);
   // Only note subresources with certificate errors if the main resource was
   // loaded without major certificate errors. If the main resource had a
   // certificate error, then it would not be that useful (and could
   // potentially be confusing) to warn about subresources that had certificate
   // errors too.
   if (!net::IsCertStatusError(security_info.cert_status) ||
       net::IsCertStatusMinorError(security_info.cert_status)) {
     CheckContentStatus(security_info.content_with_cert_errors_status,
                        &displayed_insecure_content, &ran_insecure_content);
   }
 
   // Only one insecure content warning is displayed; show the most severe.
   if (ran_insecure_content) {
-    connection_status =
+    *connection_status =
         PageInfo::SITE_CONNECTION_STATUS_INSECURE_ACTIVE_SUBRESOURCE;
-    connection_details.assign(l10n_util::GetStringFUTF16(
-        IDS_PAGE_INFO_SECURITY_TAB_ENCRYPTED_SENTENCE_LINK, connection_details,
+    connection_details->assign(l10n_util::GetStringFUTF16(
+        IDS_PAGE_INFO_SECURITY_TAB_ENCRYPTED_SENTENCE_LINK, *connection_details,
         l10n_util::GetStringUTF16(
             IDS_PAGE_INFO_SECURITY_TAB_ENCRYPTED_INSECURE_CONTENT_ERROR)));
     return;
   }
   if (security_info.contained_mixed_form) {
-    connection_status = PageInfo::SITE_CONNECTION_STATUS_INSECURE_FORM_ACTION;
-    connection_details.assign(l10n_util::GetStringFUTF16(
-        IDS_PAGE_INFO_SECURITY_TAB_ENCRYPTED_SENTENCE_LINK, connection_details,
+    *connection_status = PageInfo::SITE_CONNECTION_STATUS_INSECURE_FORM_ACTION;
+    connection_details->assign(l10n_util::GetStringFUTF16(
+        IDS_PAGE_INFO_SECURITY_TAB_ENCRYPTED_SENTENCE_LINK, *connection_details,
         l10n_util::GetStringUTF16(
             IDS_PAGE_INFO_SECURITY_TAB_ENCRYPTED_INSECURE_FORM_WARNING)));
     return;
   }
   if (displayed_insecure_content) {
-    connection_status =
+    *connection_status =
         PageInfo::SITE_CONNECTION_STATUS_INSECURE_PASSIVE_SUBRESOURCE;
-    connection_details.assign(l10n_util::GetStringFUTF16(
-        IDS_PAGE_INFO_SECURITY_TAB_ENCRYPTED_SENTENCE_LINK, connection_details,
+    connection_details->assign(l10n_util::GetStringFUTF16(
+        IDS_PAGE_INFO_SECURITY_TAB_ENCRYPTED_SENTENCE_LINK, *connection_details,
         l10n_util::GetStringUTF16(
             IDS_PAGE_INFO_SECURITY_TAB_ENCRYPTED_INSECURE_CONTENT_WARNING)));
   }
 }
 
 void GetSiteIdentityByMaliciousContentStatus(
     security_state::MaliciousContentStatus malicious_content_status,
     PageInfo::SiteIdentityStatus* status,
     base::string16* details) {
   switch (malicious_content_status) {
@@ skipping 413 matching lines @@
 
     if (security_info.obsolete_ssl_status == net::OBSOLETE_SSL_NONE) {
       site_connection_details_.assign(l10n_util::GetStringFUTF16(
           IDS_PAGE_INFO_SECURITY_TAB_ENCRYPTED_CONNECTION_TEXT, subject_name));
     } else {
       site_connection_details_.assign(l10n_util::GetStringFUTF16(
           IDS_PAGE_INFO_SECURITY_TAB_WEAK_ENCRYPTION_CONNECTION_TEXT,
           subject_name));
     }
 
-    ReportAnyInsecureContent(security_info, site_connection_status_,
-                             site_connection_details_);
+    ReportAnyInsecureContent(security_info, &site_connection_status_,
+                             &site_connection_details_);
   }
 
   uint16_t cipher_suite =
       net::SSLConnectionStatusToCipherSuite(security_info.connection_status);
   if (security_info.security_bits > 0 && cipher_suite) {
     int ssl_version =
         net::SSLConnectionStatusToVersion(security_info.connection_status);
     const char* ssl_version_str;
     net::SSLVersionToString(&ssl_version_str, ssl_version);
     site_connection_details_ += ASCIIToUTF16("\n\n");
@@ skipping 148 matching lines @@
     info.site_identity = UTF16ToUTF8(GetSimpleSiteName(site_url_));
 
   info.connection_status = site_connection_status_;
   info.connection_status_description = UTF16ToUTF8(site_connection_details_);
   info.identity_status = site_identity_status_;
   info.identity_status_description = UTF16ToUTF8(site_identity_details_);
   info.certificate = certificate_;
   info.show_ssl_decision_revoke_button = show_ssl_decision_revoke_button_;
   ui_->SetIdentityInfo(info);
 }