Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 2944163002: Remove unused PubCommand stuff. (Closed)

Created:
3 years, 6 months ago by Bob Nystrom
Modified:
3 years, 6 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove unused PubCommand stuff. The rest of the pub functionality was removed already, so I think this is just a straggler. R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/3144296c4f5b7f3fd9f2f320d3bc0e2012224b6e

Patch Set 1 #

Patch Set 2 : Merge branch 'master' into remove-pub-command #

Patch Set 3 : Merge branch 'master' into remove-pub-command #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -53 lines) Patch
M tools/testing/dart/command.dart View 1 2 chunks +0 lines, -29 lines 0 comments Download
M tools/testing/dart/command_output.dart View 2 chunks +0 lines, -24 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
3 years, 6 months ago (2017-06-19 22:21:57 UTC) #2
Bill Hesse
lgtm
3 years, 6 months ago (2017-06-21 15:53:31 UTC) #3
Bob Nystrom
3 years, 6 months ago (2017-06-23 19:55:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
3144296c4f5b7f3fd9f2f320d3bc0e2012224b6e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698