Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: tools/testing/dart/command_output.dart

Issue 2944163002: Remove unused PubCommand stuff. (Closed)
Patch Set: Merge branch 'master' into remove-pub-command Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/command.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/command_output.dart
diff --git a/tools/testing/dart/command_output.dart b/tools/testing/dart/command_output.dart
index 322b32ebd24087ac815aaab1eef032ef73eec64d..9b6f6e692c5af19d4f22bdb0abf8736a1b54e075 100644
--- a/tools/testing/dart/command_output.dart
+++ b/tools/testing/dart/command_output.dart
@@ -760,27 +760,6 @@ class JSCommandLineOutput extends CommandOutput
}
}
-class PubCommandOutput extends CommandOutput {
- PubCommandOutput(PubCommand command, int exitCode, bool timedOut,
- List<int> stdout, List<int> stderr, Duration time)
- : super(command, exitCode, timedOut, stdout, stderr, time, false, 0);
-
- Expectation result(TestCase testCase) {
- // Handle crashes and timeouts first.
- if (hasCrashed) return Expectation.crash;
- if (hasTimedOut) return Expectation.timeout;
- if (hasNonUtf8) return Expectation.nonUtf8Error;
-
- if (exitCode == 0) {
- return Expectation.pass;
- } else if ((command as PubCommand).command == 'get') {
- return Expectation.pubGetError;
- } else {
- return Expectation.fail;
- }
- }
-}
-
class ScriptCommandOutput extends CommandOutput {
final Expectation _result;
@@ -830,9 +809,6 @@ CommandOutput createCommandOutput(Command command, int exitCode, bool timedOut,
} else if (command is JSCommandlineCommand) {
return new JSCommandLineOutput(
command, exitCode, timedOut, stdout, stderr, time);
- } else if (command is PubCommand) {
- return new PubCommandOutput(
- command, exitCode, timedOut, stdout, stderr, time);
}
return new CommandOutput(command, exitCode, timedOut, stdout, stderr, time,
« no previous file with comments | « tools/testing/dart/command.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698