Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: tools/testing/dart/command.dart

Issue 2944163002: Remove unused PubCommand stuff. (Closed)
Patch Set: Merge branch 'master' into remove-pub-command Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testing/dart/command_output.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/command.dart
diff --git a/tools/testing/dart/command.dart b/tools/testing/dart/command.dart
index e2b50b2e733cc0dceed0615b6357bfa4a7741dac..3199d97924b6f79dd2e306b2e4ec41468eb3f197 100644
--- a/tools/testing/dart/command.dart
+++ b/tools/testing/dart/command.dart
@@ -103,13 +103,6 @@ class Command {
sourceDirectory, destinationDirectory);
}
- static Command pub(String pubCommand, String pubExecutable,
- String pubspecYamlDirectory, String pubCacheDirectory,
- {List<String> arguments: const <String>[]}) {
- return new PubCommand._(pubCommand, pubExecutable, pubspecYamlDirectory,
- pubCacheDirectory, arguments);
- }
-
static Command makeSymlink(String link, String target) {
return new MakeSymlinkCommand._(link, target);
}
@@ -479,28 +472,6 @@ class JSCommandlineCommand extends ProcessCommand {
: super._(displayName, executable, arguments, environmentOverrides);
}
-class PubCommand extends ProcessCommand {
- final String command;
-
- PubCommand._(String pubCommand, String pubExecutable,
- String pubspecYamlDirectory, String pubCacheDirectory, List<String> args)
- : command = pubCommand,
- super._(
- 'pub_$pubCommand',
- new io.File(pubExecutable).absolute.path,
- [pubCommand]..addAll(args),
- {'PUB_CACHE': pubCacheDirectory},
- pubspecYamlDirectory);
-
- void _buildHashCode(HashCodeBuilder builder) {
- super._buildHashCode(builder);
- builder.addJson(command);
- }
-
- bool _equal(PubCommand other) =>
- super._equal(other) && command == other.command;
-}
-
/// [ScriptCommand]s are executed by dart code.
abstract class ScriptCommand extends Command {
ScriptCommand._(String displayName) : super._(displayName);
« no previous file with comments | « no previous file | tools/testing/dart/command_output.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698