Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2944153003: [milo] common/config -> api/config (Closed)

Created:
3 years, 6 months ago by iannucci
Modified:
3 years, 6 months ago
Reviewers:
Ryan Tseng, estaab, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -508 lines) Patch
A + milo/api/config/generate.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/api/config/project.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/api/config/project.pb.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/api/config/settings.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + milo/api/config/settings.pb.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M milo/appengine/common/config.go View 2 chunks +4 lines, -3 lines 0 comments Download
M milo/appengine/console/console.go View 1 chunk +3 lines, -2 lines 0 comments Download
D milo/common/config/generate.go View 1 chunk +0 lines, -13 lines 0 comments Download
D milo/common/config/project.proto View 1 chunk +0 lines, -61 lines 0 comments Download
D milo/common/config/project.pb.go View 1 chunk +0 lines, -214 lines 0 comments Download
D milo/common/config/settings.proto View 1 chunk +0 lines, -46 lines 0 comments Download
D milo/common/config/settings.pb.go View 1 chunk +0 lines, -174 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
iannucci
3 years, 6 months ago (2017-06-19 23:29:11 UTC) #1
Ryan Tseng
lgtm
3 years, 6 months ago (2017-06-19 23:41:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2944153003/1
3 years, 6 months ago (2017-06-20 01:30:59 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 01:37:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/ffad7ffa473763a540bddf91e3aba599e749d25d

Powered by Google App Engine
This is Rietveld 408576698