[Payment Request] Fixes modally presented editors

[Payment Request] Fixes modally presented editors

Editor coordinators should push PaymentRequestEditViewController onto a
navigation controller and modally present the navigation controller rather
than the view controller itself. This is because the coordinator might need
to start other coordinators that expect the navigation controller property
to be set on their base view controller.

BUG=602666
Review-Url: https://codereview.chromium.org/2944083003
Cr-Commit-Position: refs/heads/master@{#480806}
Committed: https://chromium.googlesource.com/chromium/src/+/ca866e17bf86ae89f8b69400cb049e50992d1bf0

[Moe, 2017-06-20 00:11:00]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 00:11:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Moe, 2017-06-20 00:12:13]

Patchset #1 (id:1) has been deleted

[Moe, 2017-06-20 00:13:27]

Description was changed from

==========
[Payment Request] Fixes modally presented editors

Editor coordinators should push PaymentRequestEditViewController onto a
navigation controller and modally present the navigation controller rather
than the view controller itself. This is because the coordinator might need
to start other coordinators that expect a navigation controller to be set
on their base view controller.

BUG=602666
==========

to

==========
[Payment Request] Fixes modally presented editors

Editor coordinators should push PaymentRequestEditViewController onto a
navigation controller and modally present the navigation controller rather
than the view controller itself. This is because the coordinator might need
to start other coordinators that expect the navigation controller property
to be set on their base view controller.

BUG=602666
==========

[Moe, 2017-06-20 00:13:40]

mahmadi@chromium.org changed reviewers:
+ lpromero@chromium.org

[Moe, 2017-06-20 00:13:41]

Hi Louis, Please take a look.

[commit-bot: I haz the power, 2017-06-20 02:12:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 02:12:37]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_TIMED_OUT, build has not
started yet; builder either lacks capacity or does not exist (misspelled?))

[lpromero, 2017-06-20 08:46:05]

https://codereview.chromium.org/2944083003/diff/20001/ios/chrome/browser/ui/p...
File ios/chrome/browser/ui/payments/address_edit_coordinator.mm (right):

https://codereview.chromium.org/2944083003/diff/20001/ios/chrome/browser/ui/p...
ios/chrome/browser/ui/payments/address_edit_coordinator.mm:38:
@property(nonatomic, strong) UINavigationController* navigationController;
I think I'd go the other way. The nav controller is self.viewController and you
keep a new variable for the edit view controller if needed. That way the
coordinator's viewController property is really the one being presented.

[Moe, 2017-06-20 13:33:00]

Thank you Louis, PTAL?

https://codereview.chromium.org/2944083003/diff/20001/ios/chrome/browser/ui/p...
File ios/chrome/browser/ui/payments/address_edit_coordinator.mm (right):

https://codereview.chromium.org/2944083003/diff/20001/ios/chrome/browser/ui/p...
ios/chrome/browser/ui/payments/address_edit_coordinator.mm:38:
@property(nonatomic, strong) UINavigationController* navigationController;
On 2017/06/20 at 08:46:05, lpromero wrote:
> I think I'd go the other way. The nav controller is self.viewController and
you keep a new variable for the edit view controller if needed. That way the
coordinator's viewController property is really the one being presented.

Done.

[lpromero, 2017-06-20 13:39:11]

The CQ bit was checked by lpromero@chromium.org

[lpromero, 2017-06-20 13:39:12]

lgtm

Thanks!

[commit-bot: I haz the power, 2017-06-20 13:39:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 14:04:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497965951371250,
"parent_rev": "f5942a68c48febe2525edd47eccc8256b47b6b5f", "commit_rev":
"ca866e17bf86ae89f8b69400cb049e50992d1bf0"}

[commit-bot: I haz the power, 2017-06-20 14:04:42]

Description was changed from

==========
[Payment Request] Fixes modally presented editors

Editor coordinators should push PaymentRequestEditViewController onto a
navigation controller and modally present the navigation controller rather
than the view controller itself. This is because the coordinator might need
to start other coordinators that expect the navigation controller property
to be set on their base view controller.

BUG=602666
==========

to

==========
[Payment Request] Fixes modally presented editors

Editor coordinators should push PaymentRequestEditViewController onto a
navigation controller and modally present the navigation controller rather
than the view controller itself. This is because the coordinator might need
to start other coordinators that expect the navigation controller property
to be set on their base view controller.

BUG=602666

Review-Url: https://codereview.chromium.org/2944083003
Cr-Commit-Position: refs/heads/master@{#480806}
Committed:
https://chromium.googlesource.com/chromium/src/+/ca866e17bf86ae89f8b69400cb04...
==========

[commit-bot: I haz the power, 2017-06-20 14:04:44]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ca866e17bf86ae89f8b69400cb04...