Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: ios/chrome/browser/ui/payments/address_edit_coordinator_unittest.mm

Issue 2944083003: [Payment Request] Fixes modally presented editors (Closed)
Patch Set: Addressed comment Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/payments/address_edit_coordinator_unittest.mm
diff --git a/ios/chrome/browser/ui/payments/address_edit_coordinator_unittest.mm b/ios/chrome/browser/ui/payments/address_edit_coordinator_unittest.mm
index f3467634413f96f9be506208ebe301967fa4e320..f46eaf9f7919c7c349e021cd46bfd539e1a08eee 100644
--- a/ios/chrome/browser/ui/payments/address_edit_coordinator_unittest.mm
+++ b/ios/chrome/browser/ui/payments/address_edit_coordinator_unittest.mm
@@ -144,6 +144,11 @@ TEST_F(PaymentRequestAddressEditCoordinatorTest, StartAndStop) {
// Spin the run loop to trigger the animation.
base::test::ios::SpinRunLoopWithMaxDelay(base::TimeDelta::FromSecondsD(1.0));
EXPECT_TRUE([base_view_controller.presentedViewController
+ isMemberOfClass:[UINavigationController class]]);
+ UINavigationController* navigation_controller =
+ base::mac::ObjCCastStrict<UINavigationController>(
+ base_view_controller.presentedViewController);
+ EXPECT_TRUE([navigation_controller.visibleViewController
isMemberOfClass:[PaymentRequestEditViewController class]]);
[coordinator stop];
@@ -201,9 +206,14 @@ TEST_F(PaymentRequestAddressEditCoordinatorTest, DidFinishCreating) {
EXPECT_CALL(*profile_comparator_, Invalidate(_)).Times(0);
// Call the controller delegate method.
+ EXPECT_TRUE([base_view_controller.presentedViewController
+ isMemberOfClass:[UINavigationController class]]);
+ UINavigationController* navigation_controller =
+ base::mac::ObjCCastStrict<UINavigationController>(
+ base_view_controller.presentedViewController);
PaymentRequestEditViewController* view_controller =
base::mac::ObjCCastStrict<PaymentRequestEditViewController>(
- base_view_controller.presentedViewController);
+ navigation_controller.visibleViewController);
[coordinator paymentRequestEditViewController:view_controller
didFinishEditingFields:GetEditorFields()];
@@ -260,9 +270,14 @@ TEST_F(PaymentRequestAddressEditCoordinatorTest, DidFinishEditing) {
.Times(1);
// Call the controller delegate method.
+ EXPECT_TRUE([base_view_controller.presentedViewController
+ isMemberOfClass:[UINavigationController class]]);
+ UINavigationController* navigation_controller =
+ base::mac::ObjCCastStrict<UINavigationController>(
+ base_view_controller.presentedViewController);
PaymentRequestEditViewController* view_controller =
base::mac::ObjCCastStrict<PaymentRequestEditViewController>(
- base_view_controller.presentedViewController);
+ navigation_controller.visibleViewController);
[coordinator paymentRequestEditViewController:view_controller
didFinishEditingFields:GetEditorFields()];
@@ -295,9 +310,14 @@ TEST_F(PaymentRequestAddressEditCoordinatorTest, DidCancel) {
EXPECT_NE(nil, base_view_controller.presentedViewController);
// Call the controller delegate method.
+ EXPECT_TRUE([base_view_controller.presentedViewController
+ isMemberOfClass:[UINavigationController class]]);
+ UINavigationController* navigation_controller =
+ base::mac::ObjCCastStrict<UINavigationController>(
+ base_view_controller.presentedViewController);
PaymentRequestEditViewController* view_controller =
base::mac::ObjCCastStrict<PaymentRequestEditViewController>(
- base_view_controller.presentedViewController);
+ navigation_controller.visibleViewController);
[coordinator paymentRequestEditViewControllerDidCancel:view_controller];
EXPECT_OCMOCK_VERIFY(delegate);

Powered by Google App Engine
This is Rietveld 408576698