Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2944013002: Remove TypeFeedbackId parameters from assembler and full-code. (Closed)

Created:
3 years, 6 months ago by mvstanton
Modified:
3 years, 6 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Remove TypeFeedbackId parameters from assembler and full-code. These are no longer being used. BUG=v8:6408 Review-Url: https://codereview.chromium.org/2944013002 Cr-Commit-Position: refs/heads/master@{#46024} Committed: https://chromium.googlesource.com/v8/v8/+/a42473abb7c80cada930a07168ad78a3ac394619

Patch Set 1 #

Patch Set 2 : REBASE+fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -271 lines) Patch
M src/arm/assembler-arm.h View 2 chunks +0 lines, -19 lines 0 comments Download
M src/arm/assembler-arm.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 3 chunks +2 lines, -6 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 3 chunks +5 lines, -14 lines 0 comments Download
M src/arm64/assembler-arm64.h View 1 chunk +0 lines, -15 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M src/arm64/assembler-arm64-inl.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 3 chunks +3 lines, -6 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 3 chunks +5 lines, -17 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/assembler-ia32.h View 2 chunks +3 lines, -9 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/ia32/assembler-ia32-inl.h View 1 chunk +4 lines, -11 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 2 chunks +2 lines, -5 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/assembler-mips.h View 2 chunks +0 lines, -19 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 3 chunks +3 lines, -12 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 6 chunks +3 lines, -11 lines 0 comments Download
M src/mips64/assembler-mips64.h View 2 chunks +0 lines, -19 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 1 3 chunks +3 lines, -12 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 2 chunks +1 line, -5 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 6 chunks +4 lines, -12 lines 0 comments Download
M src/x64/assembler-x64.h View 2 chunks +2 lines, -5 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 1 chunk +2 lines, -9 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +4 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (13 generated)
mvstanton
Hi Michael, Here is the first of some CLs we discussed. And Ross, as owner ...
3 years, 6 months ago (2017-06-19 14:05:50 UTC) #9
Michael Starzinger
LGTM. Nice. Thanks!
3 years, 6 months ago (2017-06-19 14:29:15 UTC) #10
rmcilroy
Awesome, LGTM, thanks.
3 years, 6 months ago (2017-06-20 08:00:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2944013002/20001
3 years, 6 months ago (2017-06-20 08:01:16 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 08:03:00 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/a42473abb7c80cada930a07168ad78a3ac3...

Powered by Google App Engine
This is Rietveld 408576698