Remove enum RelocInfo::CODE_TARGET_WITH_ID.

Remove enum RelocInfo::CODE_TARGET_WITH_ID.

RelocInfo no longer needs CODE_TARGET_WITH_ID thanks to the removal
of Crankshaft.

BUG=v8:6408
R=mstarzinger@chromium.org

Review-Url: https://codereview.chromium.org/2951473002
Cr-Commit-Position: refs/heads/master@{#46047}
Committed: https://chromium.googlesource.com/v8/v8/+/b2b38f00c05d6a6c2e2339af1eff0a1527c734f2

[mvstanton, 2017-06-19 15:07:47]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-19 15:07:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mvstanton, 2017-06-19 15:08:39]

Hi Michael,
Here is a follow on. Removes TypeFeedbackId (as an aside), but mainly tightens
up the RelocInfo to only express what is necessary.

[commit-bot: I haz the power, 2017-06-19 15:11:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 15:11:04]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[mvstanton, 2017-06-19 15:15:08]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-19 15:15:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 15:49:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 15:49:05]

Dry run: This issue passed the CQ dry run.

[mvstanton, 2017-06-20 08:30:15]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 08:30:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 08:58:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 08:58:42]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2017-06-20 10:42:07]

https://codereview.chromium.org/2951473002/diff/1/src/assembler.h
File src/assembler.h (right):

https://codereview.chromium.org/2951473002/diff/1/src/assembler.h#newcode644
src/assembler.h:644: static const int kDataMask = (1 << EMBEDDED_OBJECT) | (1 <<
COMMENT);
question: Why was EMBEDDED_OBJECT added here? Also, I noticed that the kDataMask
seems to be unused, can we drop it completely?

https://codereview.chromium.org/2951473002/diff/1/src/assembler.h#newcode698
src/assembler.h:698: inline void WriteShortTaggedData(intptr_t data_delta);
nit: I would suggest s/WriteShortTaggedData/WriteShortData/, WDYT?

https://codereview.chromium.org/2951473002/diff/1/src/assembler.h#newcode751
src/assembler.h:751: void ReadShortTaggedData();
nit: Likewise, I'd suggest s/ReadShortTaggedData/ReadShortData/, WDYT?

[mvstanton, 2017-06-20 12:57:33]

Hi Michael,
Thanks for the comments, updated...
--Michael

https://codereview.chromium.org/2951473002/diff/1/src/assembler.h
File src/assembler.h (right):

https://codereview.chromium.org/2951473002/diff/1/src/assembler.h#newcode644
src/assembler.h:644: static const int kDataMask = (1 << EMBEDDED_OBJECT) | (1 <<
COMMENT);
On 2017/06/20 10:42:07, Michael Starzinger wrote:
> question: Why was EMBEDDED_OBJECT added here? Also, I noticed that the
kDataMask
> seems to be unused, can we drop it completely?

It was a mechanical move forward to the next enum in that range.
And indeed...you are right -- now removed!

https://codereview.chromium.org/2951473002/diff/1/src/assembler.h#newcode698
src/assembler.h:698: inline void WriteShortTaggedData(intptr_t data_delta);
On 2017/06/20 10:42:07, Michael Starzinger wrote:
> nit: I would suggest s/WriteShortTaggedData/WriteShortData/, WDYT?

Done.

https://codereview.chromium.org/2951473002/diff/1/src/assembler.h#newcode751
src/assembler.h:751: void ReadShortTaggedData();
On 2017/06/20 10:42:07, Michael Starzinger wrote:
> nit: Likewise, I'd suggest s/ReadShortTaggedData/ReadShortData/, WDYT?

Done.

[mvstanton, 2017-06-20 12:57:46]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 12:57:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Starzinger, 2017-06-20 13:00:25]

LGTM. Thanks!

[mvstanton, 2017-06-20 13:19:27]

The CQ bit was checked by mvstanton@chromium.org

[commit-bot: I haz the power, 2017-06-20 13:19:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 13:30:18]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497964767384410,
"parent_rev": "b102540e44a72157098014a20399193a461153d2", "commit_rev":
"b2b38f00c05d6a6c2e2339af1eff0a1527c734f2"}

[commit-bot: I haz the power, 2017-06-20 13:30:24]

Description was changed from

==========
Remove enum RelocInfo::CODE_TARGET_WITH_ID.

RelocInfo no longer needs CODE_TARGET_WITH_ID thanks to the removal
of Crankshaft.

BUG=v8:6408
R=mstarzinger@chromium.org
==========

to

==========
Remove enum RelocInfo::CODE_TARGET_WITH_ID.

RelocInfo no longer needs CODE_TARGET_WITH_ID thanks to the removal
of Crankshaft.

BUG=v8:6408
R=mstarzinger@chromium.org

Review-Url: https://codereview.chromium.org/2951473002
Cr-Commit-Position: refs/heads/master@{#46047}
Committed:
https://chromium.googlesource.com/v8/v8/+/b2b38f00c05d6a6c2e2339af1eff0a1527c...
==========

[commit-bot: I haz the power, 2017-06-20 13:30:25]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/b2b38f00c05d6a6c2e2339af1eff0a1527c...