Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2943783002:
Make iOS's IOThread set up the SystemURLRequestContext all at once. (Closed)
DescriptionMake iOS's IOThread set up the SystemURLRequestContext all at once.
It was jumping back to the UI thread and back because the
PrefProxyConfigTracker required it. Now that that's no longer the
case, get rid of the extra thread hops. The same thing has already
been done to chrome/'s IOThead.
BUG=734199
Review-Url: https://codereview.chromium.org/2943783002
Cr-Commit-Position: refs/heads/master@{#485906}
Committed: https://chromium.googlesource.com/chromium/src/+/3e90690d092c46535ebabcedaab4c8514c3c0094
Patch Set 1 #Patch Set 2 : Oops #
Dependent Patchsets: Messages
Total messages: 26 (22 generated)
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #3 (id:40001) has been deleted
Patchset #2 (id:20001) has been deleted
mmenke@chromium.org changed reviewers: + sdefresne@chromium.org
This is a preliminary CL for moving this file over to using URLRequestContextBuilder (Like chrome/browser/io_thread.h now does). In chrome/ code, that's a prerequisite for switching over to using the network service, and ideally removing io_thread.h entirely. Not sure if we'll go the same way with iOS, but it will at least simplify the code, and make it easier to modify URLRequestContext setup.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by mmenke@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1499852514994690,
"parent_rev": "8aec1567a9b44547797db47c5f6a3f392f6fa3d9", "commit_rev":
"3e90690d092c46535ebabcedaab4c8514c3c0094"}
Message was sent while issue was closed.
Description was changed from ========== Make iOS's IOThread set up the SystemURLRequestContext all at once. It was jumping back to the UI thread and back because the PrefProxyConfigTracker required it. Now that that's no longer the case, get rid of the extra thread hops. The same thing has already been done to chrome/'s IOThead. BUG=734199 ========== to ========== Make iOS's IOThread set up the SystemURLRequestContext all at once. It was jumping back to the UI thread and back because the PrefProxyConfigTracker required it. Now that that's no longer the case, get rid of the extra thread hops. The same thing has already been done to chrome/'s IOThead. BUG=734199 Review-Url: https://codereview.chromium.org/2943783002 Cr-Commit-Position: refs/heads/master@{#485906} Committed: https://chromium.googlesource.com/chromium/src/+/3e90690d092c46535ebabcedaab4... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as https://chromium.googlesource.com/chromium/src/+/3e90690d092c46535ebabcedaab4... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
