Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2946533002: Make iOS's IOThread class use URLRequestContextBuilder.

Created:
3 years, 6 months ago by mmenke
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make iOS's IOThread class use URLRequestContextBuilder. BUG=734199

Patch Set 1 #

Patch Set 2 : Remove a couple more headers #

Patch Set 3 : Minor fix, more needed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -147 lines) Patch
M ios/components/io_thread/ios_io_thread.h View 1 2 3 chunks +0 lines, -42 lines 0 comments Download
M ios/components/io_thread/ios_io_thread.mm View 1 2 5 chunks +13 lines, -105 lines 0 comments Download

Depends on Patchset:

Issue 2943783002 Patch 60001

Messages

Total messages: 10 (10 generated)
mmenke
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-16 21:29:05 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2946533002/1
3 years, 6 months ago (2017-06-16 21:29:23 UTC) #2
mmenke
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-16 21:35:17 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2946533002/20001
3 years, 6 months ago (2017-06-16 21:35:43 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-16 21:48:58 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xcode-clang/builds/122561)
3 years, 6 months ago (2017-06-16 21:48:59 UTC) #6
mmenke
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-16 21:57:53 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2946533002/40001
3 years, 6 months ago (2017-06-16 21:58:18 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-16 22:13:50 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 22:13:51 UTC) #10 
Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

Powered by Google App Engine
This is Rietveld 408576698