[wasm] SIMD/Atomics ops update to use the right prefix opcodes

[wasm] SIMD/Atomics ops update to use the right prefix opcodes
 - Use correct prefixes for SIMD/Atomics ops
 - S128 LoadMem/StoreMem should not use 0xc0/0xc1 opcodes, these are now
 being used for sign extension
 - S128 LoadMem/StoreMem should use prefixed opcodes

BUG=v8:6020
Review-Url: https://codereview.chromium.org/2943773002
Cr-Commit-Position: refs/heads/master@{#46016}
Committed: https://chromium.googlesource.com/v8/v8/+/631c429f9a90451d0909b88301a0c06e92ef3af5

[gdeepti, 2017-06-16 20:35:09]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 20:35:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gdeepti, 2017-06-16 20:37:36]

Description was changed from

==========
[wasm] Opcode fixups after the latest CG meeting
 - Use correct prefixes for SIMD/Atomics ops
 - S128 LoadMem/StoreMem should not use 0xc0/0xc1 opcodes, these are now
 being used for sign extension
 - S128 LoadMem/StoreMem should use prefixed opcodes

BUG=v8:6020
==========

to

==========
[wasm] SIMD/Atomics ops update to use the right prefix opcodes
 - Use correct prefixes for SIMD/Atomics ops
 - S128 LoadMem/StoreMem should not use 0xc0/0xc1 opcodes, these are now
 being used for sign extension
 - S128 LoadMem/StoreMem should use prefixed opcodes

BUG=v8:6020
==========

[gdeepti, 2017-06-16 20:37:36]

gdeepti@chromium.org changed reviewers:
+ bbudge@chromium.org, binji@chromium.org

[commit-bot: I haz the power, 2017-06-16 21:02:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 21:02:19]

Dry run: This issue passed the CQ dry run.

[binji, 2017-06-16 21:58:18]

https://codereview.chromium.org/2943773002/diff/20001/src/wasm/wasm-opcodes.h
File src/wasm/wasm-opcodes.h (right):

https://codereview.chromium.org/2943773002/diff/20001/src/wasm/wasm-opcodes.h...
src/wasm/wasm-opcodes.h:416: V(I32AtomicAdd8S, 0xfe01, i_ii)              \
The sign-extending atomic operators have been removed.

https://codereview.chromium.org/2943773002/diff/20001/src/wasm/wasm-opcodes.h...
src/wasm/wasm-opcodes.h:417: V(I32AtomicAdd8U, 0xfe02, i_ii)              \
Please use the opcodes defined here:
https://github.com/WebAssembly/threads/blob/master/proposals/threads/Overview...

e.g. i32.atomic.rmw8_u.add is 0xfe20

[gdeepti, 2017-06-16 23:05:20]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 23:05:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 23:20:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 23:20:59]

Dry run: Try jobs failed on following builders:
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux64_verify_csa_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)

[gdeepti, 2017-06-16 23:37:40]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 23:37:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gdeepti, 2017-06-16 23:49:29]

https://codereview.chromium.org/2943773002/diff/20001/src/wasm/wasm-opcodes.h
File src/wasm/wasm-opcodes.h (right):

https://codereview.chromium.org/2943773002/diff/20001/src/wasm/wasm-opcodes.h...
src/wasm/wasm-opcodes.h:416: V(I32AtomicAdd8S, 0xfe01, i_ii)              \
On 2017/06/16 21:58:18, binji wrote:
> The sign-extending atomic operators have been removed.

Done.

https://codereview.chromium.org/2943773002/diff/20001/src/wasm/wasm-opcodes.h...
src/wasm/wasm-opcodes.h:417: V(I32AtomicAdd8U, 0xfe02, i_ii)              \
On 2017/06/16 21:58:18, binji wrote:
> Please use the opcodes defined here:
>
https://github.com/WebAssembly/threads/blob/master/proposals/threads/Overview...
> 
> e.g. i32.atomic.rmw8_u.add is 0xfe20

Not sure if these are hooked up to anything yet, so just pruned, numbered and
reordered existing opcodes as in the threads overview.

[commit-bot: I haz the power, 2017-06-17 00:03:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-17 00:03:19]

Dry run: This issue passed the CQ dry run.

[binji, 2017-06-17 00:14:04]

atomics lgtm

https://codereview.chromium.org/2943773002/diff/60001/src/wasm/wasm-opcodes.h
File src/wasm/wasm-opcodes.h (right):

https://codereview.chromium.org/2943773002/diff/60001/src/wasm/wasm-opcodes.h...
src/wasm/wasm-opcodes.h:434: V(I32AtomicCompareExchange, 0xfe48, i_ii)   \
CompareExchange actually has signature i_iii, but I guess we can fix that when
it's actually used.

[bbudge, 2017-06-19 18:56:22]

Nice, LGTM

[gdeepti, 2017-06-19 18:57:00]

The CQ bit was checked by gdeepti@chromium.org

[commit-bot: I haz the power, 2017-06-19 18:57:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 19:23:12]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497898620152930,
"parent_rev": "ea241630ae1a258655bd22bf7979617ec29e1de2", "commit_rev":
"631c429f9a90451d0909b88301a0c06e92ef3af5"}

[commit-bot: I haz the power, 2017-06-19 19:23:19]

Description was changed from

==========
[wasm] SIMD/Atomics ops update to use the right prefix opcodes
 - Use correct prefixes for SIMD/Atomics ops
 - S128 LoadMem/StoreMem should not use 0xc0/0xc1 opcodes, these are now
 being used for sign extension
 - S128 LoadMem/StoreMem should use prefixed opcodes

BUG=v8:6020
==========

to

==========
[wasm] SIMD/Atomics ops update to use the right prefix opcodes
 - Use correct prefixes for SIMD/Atomics ops
 - S128 LoadMem/StoreMem should not use 0xc0/0xc1 opcodes, these are now
 being used for sign extension
 - S128 LoadMem/StoreMem should use prefixed opcodes

BUG=v8:6020

Review-Url: https://codereview.chromium.org/2943773002
Cr-Commit-Position: refs/heads/master@{#46016}
Committed:
https://chromium.googlesource.com/v8/v8/+/631c429f9a90451d0909b88301a0c06e92e...
==========

[commit-bot: I haz the power, 2017-06-19 19:23:19]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/631c429f9a90451d0909b88301a0c06e92e...