Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: src/wasm/wasm-opcodes.cc

Issue 2943773002: [wasm] SIMD/Atomics ops update to use the right prefix opcodes (Closed)
Patch Set: Fix opcode names Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/wasm/wasm-opcodes.cc
diff --git a/src/wasm/wasm-opcodes.cc b/src/wasm/wasm-opcodes.cc
index 565eeb4face7a32ca3debe75e6b9b9004a66229f..ba336b40365a13eb6adbde7f19967ca1ae7db75e 100644
--- a/src/wasm/wasm-opcodes.cc
+++ b/src/wasm/wasm-opcodes.cc
@@ -43,6 +43,7 @@ namespace wasm {
CASE_I32x4_OP(name, str) CASE_I16x8_OP(name, str) CASE_I8x16_OP(name, str)
#define CASE_SIGN_OP(TYPE, name, str) \
CASE_##TYPE##_OP(name##S, str "_s") CASE_##TYPE##_OP(name##U, str "_u")
+#define CASE_UNSIGNED_OP(TYPE, name, str) CASE_##TYPE##_OP(name##U, str "_u")
#define CASE_ALL_SIGN_OP(name, str) \
CASE_FLOAT_OP(name, str) CASE_SIGN_OP(INT, name, str)
#define CASE_CONVERT_OP(name, RES, SRC, src_suffix, str) \
@@ -52,6 +53,10 @@ namespace wasm {
CASE_SIGN_OP(I32, name##8, str "8") \
CASE_SIGN_OP(I32, name##16, str "16") \
CASE_I32_OP(name, str "32")
+#define CASE_U32_OP(name, str) \
+ CASE_I32_OP(name, str "32") \
+ CASE_UNSIGNED_OP(I32, name##8, str "8") \
+ CASE_UNSIGNED_OP(I32, name##16, str "16")
const char* WasmOpcodes::OpcodeName(WasmOpcode opcode) {
switch (opcode) {
@@ -228,13 +233,13 @@ const char* WasmOpcodes::OpcodeName(WasmOpcode opcode) {
CASE_S1x16_OP(AllTrue, "all_true")
// Atomic operations.
- CASE_L32_OP(AtomicAdd, "atomic_add")
- CASE_L32_OP(AtomicAnd, "atomic_and")
- CASE_L32_OP(AtomicCompareExchange, "atomic_cmpxchng")
- CASE_L32_OP(AtomicExchange, "atomic_xchng")
- CASE_L32_OP(AtomicOr, "atomic_or")
- CASE_L32_OP(AtomicSub, "atomic_sub")
- CASE_L32_OP(AtomicXor, "atomic_xor")
+ CASE_U32_OP(AtomicAdd, "atomic_add")
+ CASE_U32_OP(AtomicSub, "atomic_sub")
+ CASE_U32_OP(AtomicAnd, "atomic_and")
+ CASE_U32_OP(AtomicOr, "atomic_or")
+ CASE_U32_OP(AtomicXor, "atomic_xor")
+ CASE_U32_OP(AtomicExchange, "atomic_xchng")
+ CASE_U32_OP(AtomicCompareExchange, "atomic_cmpxchng")
default : return "unknown";
// clang-format on
« src/wasm/wasm-opcodes.h ('K') | « src/wasm/wasm-opcodes.h ('k') | src/wasm/wasm-text.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698