Fire start/stop based on Frame::IsLoading for same document navigations

Fire start/stop based on Frame::IsLoading for same document navigations

Prior to this change, DidStartLoading/DidStopLoading is fired for
same document navigations based on a heuristic similar to (but not
exactly the same as) the heuristic that changes the Frame loading bit.
There's no reason to have multiple different definitions, and this
should prevent a situation in which we have interleaved start/stop
notifications (or 2 starts but only 1 stop).

BUG=

Review-Url: https://codereview.chromium.org/2943523002
Cr-Commit-Position: refs/heads/master@{#480968}
Committed: https://chromium.googlesource.com/chromium/src/+/f52c295d282cfb4c88f075008d53c9daec7da71e

[Nate Chapin, 2017-06-15 20:22:17]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-15 20:22:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 22:26:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 22:26:06]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nate Chapin, 2017-06-19 16:14:56]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-19 16:15:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 17:38:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 17:38:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nate Chapin, 2017-06-19 18:26:44]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-19 18:27:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 20:37:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 20:37:22]

Dry run: This issue passed the CQ dry run.

[Nate Chapin, 2017-06-19 20:48:44]

Description was changed from

==========
Fire start/stop based on IsLoading

BUG=
==========

to

==========
Fire start/stop based on Frame::IsLoading for same document navigations

Prior to this change, DidStartLoading/DidStopLoading is fired for
same document navigations based on a heuristic similar to (but not
exactly the same as) the heuristic that changes the Frame loading bit.
There's no reason to have multiple different definitions, and this
should prevent a situation in which we have interleaved start/stop
notifications (or 2 starts but only 1 stop).

BUG=
==========

[Nate Chapin, 2017-06-19 20:49:31]

japhet@chromium.org changed reviewers:
+ dcheng@chromium.org

[Nate Chapin, 2017-06-19 20:49:32]

dcheng, WDYT?

https://codereview.chromium.org/2943523002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/FrameLoader.cpp (left):

https://codereview.chromium.org/2943523002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/FrameLoader.cpp:512:
Client()->DispatchDidReceiveTitle(frame_->GetDocument()->title());
DispatchDidReceiveTitle should be called whenever the title is changed, so this
call here shouldn't be necessary.

[dcheng, 2017-06-20 08:28:53]

LGTM - seems like a great cleanup to me.

[Nate Chapin, 2017-06-20 18:35:16]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2017-06-20 18:35:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 21:39:14]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497983716728800,
"parent_rev": "1224282a2b37f845b160dbc8cd8dc59051ea3399", "commit_rev":
"f52c295d282cfb4c88f075008d53c9daec7da71e"}

[commit-bot: I haz the power, 2017-06-20 21:39:26]

Description was changed from

==========
Fire start/stop based on Frame::IsLoading for same document navigations

Prior to this change, DidStartLoading/DidStopLoading is fired for
same document navigations based on a heuristic similar to (but not
exactly the same as) the heuristic that changes the Frame loading bit.
There's no reason to have multiple different definitions, and this
should prevent a situation in which we have interleaved start/stop
notifications (or 2 starts but only 1 stop).

BUG=
==========

to

==========
Fire start/stop based on Frame::IsLoading for same document navigations

Prior to this change, DidStartLoading/DidStopLoading is fired for
same document navigations based on a heuristic similar to (but not
exactly the same as) the heuristic that changes the Frame loading bit.
There's no reason to have multiple different definitions, and this
should prevent a situation in which we have interleaved start/stop
notifications (or 2 starts but only 1 stop).

BUG=

Review-Url: https://codereview.chromium.org/2943523002
Cr-Commit-Position: refs/heads/master@{#480968}
Committed:
https://chromium.googlesource.com/chromium/src/+/f52c295d282cfb4c88f075008d53...
==========

[commit-bot: I haz the power, 2017-06-20 21:39:28]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f52c295d282cfb4c88f075008d53...