Fire start/stop based on Frame::IsLoading for same document navigations

third_party/WebKit/Source/core/loader/FrameLoader.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  * Copyright (C) 2008 Alp Toker <alp@atoker.com>
  * Copyright (C) Research In Motion Limited 2009. All rights reserved.
  * Copyright (C) 2011 Kris Jordan <krisjordan@gmail.com>
  * Copyright (C) 2011 Google Inc. All rights reserved.
@@ skipping 481 matching lines @@
     FrameLoadType type,
     Document* initiating_document) {
   TRACE_EVENT1("blink", "FrameLoader::updateForSameDocumentNavigation", "url",
                new_url.GetString().Ascii().data());
 
   // Generate start and stop notifications only when loader is completed so that
   // we don't fire them for fragment redirection that happens in window.onload
   // handler. See https://bugs.webkit.org/show_bug.cgi?id=31838
   // Do not fire the notifications if the frame is concurrently navigating away
   // from the document, since a new document is already loading.
-  if (frame_->GetDocument()->LoadEventFinished() &&
-      !provisional_document_loader_)
+  bool was_loading = frame_->IsLoading();
+  if (!was_loading)
     Client()->DidStartLoading(kNavigationWithinSameDocument);
 
   // Update the data source's request with the new URL to fake the URL change
   frame_->GetDocument()->SetURL(new_url);
   GetDocumentLoader()->UpdateForSameDocumentNavigation(
       new_url, same_document_navigation_source, std::move(data),
       scroll_restoration_type, type, initiating_document);
-
-  Client()->DispatchDidReceiveTitle(frame_->GetDocument()->title());

[Nate Chapin, 2017/06/19 20:49:31]

DispatchDidReceiveTitle should be called whenever the title is changed, so this
call here shouldn't be necessary.

-  if (frame_->GetDocument()->LoadEventFinished() &&
-      !provisional_document_loader_)
+  if (!was_loading)
     Client()->DidStopLoading();
 }
 
 void FrameLoader::DetachDocumentLoader(Member<DocumentLoader>& loader) {
   if (!loader)
     return;
 
   FrameNavigationDisabler navigation_disabler(*frame_);
   loader->DetachFromFrame();
   loader = nullptr;
@@ skipping 1167 matching lines @@
   // TODO(japhet): This is needed because the browser process DCHECKs if the
   // first entry we commit in a new frame has replacement set. It's unclear
   // whether the DCHECK is right, investigate removing this special case.
   bool replace_current_item = load_type == kFrameLoadTypeReplaceCurrentItem &&
                               (!Opener() || !request.Url().IsEmpty());
   loader->SetReplacesCurrentHistoryItem(replace_current_item);
   return loader;
 }
 
 }  // namespace blink