Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2943453002: ServiceWorker: Change CHECK to DHECK in ServiceWorkerContextCore (Closed)

Created:
3 years, 6 months ago by xiaofengzhang
Modified:
3 years, 6 months ago
Reviewers:
shimazu, nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Change CHECK to DHECK in ServiceWorkerContextCore This is a follow-up work after the bug is fixed. BUG=619294 Review-Url: https://codereview.chromium.org/2943453002 Cr-Commit-Position: refs/heads/master@{#479674} Committed: https://chromium.googlesource.com/chromium/src/+/14c3371a8f2bb2ea82fd8c4fa5c36851b59325dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M content/browser/service_worker/service_worker_context_core.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
xiaofengzhang
Hi nhiroki and shimazu, This is a small code clean-up, PTAL, thanks.
3 years, 6 months ago (2017-06-15 08:22:21 UTC) #4
shimazu
lgtm, thanks!
3 years, 6 months ago (2017-06-15 08:24:29 UTC) #5
nhiroki
LGTM. Thank you.
3 years, 6 months ago (2017-06-15 08:27:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2943453002/1
3 years, 6 months ago (2017-06-15 12:07:43 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 12:12:14 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/14c3371a8f2bb2ea82fd8c4fa5c3...

Powered by Google App Engine
This is Rietveld 408576698