Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: content/browser/service_worker/service_worker_context_core.cc

Issue 2943453002: ServiceWorker: Change CHECK to DHECK in ServiceWorkerContextCore (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_context_core.cc
diff --git a/content/browser/service_worker/service_worker_context_core.cc b/content/browser/service_worker/service_worker_context_core.cc
index 72e7e6d7ffc1f59a6ff610f21bbc205b83243867..84aaee30c6eefdfee48b91e8989fa4829597f7ed 100644
--- a/content/browser/service_worker/service_worker_context_core.cc
+++ b/content/browser/service_worker/service_worker_context_core.cc
@@ -556,9 +556,7 @@ ServiceWorkerRegistration* ServiceWorkerContextCore::GetLiveRegistration(
void ServiceWorkerContextCore::AddLiveRegistration(
ServiceWorkerRegistration* registration) {
- // TODO(nhiroki): Change CHECK to DCHECK after https://crbug.com/619294 is
- // fixed.
- CHECK(!GetLiveRegistration(registration->id()));
+ DCHECK(!GetLiveRegistration(registration->id()));
live_registrations_[registration->id()] = registration;
if (observer_list_.get()) {
observer_list_->Notify(FROM_HERE,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698