Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: third_party/WebKit/LayoutTests/transforms/cssmatrix-2d-interface.xhtml

Issue 2943213002: Revert of Make WebKitCSSMatrix an alias of DOMMatrix (Closed)
Patch Set: Revert of Make WebKitCSSMatrix an alias of DOMMatrix (patchset #16 id:300001 of https://codereview.… Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/transforms/cssmatrix-2d-interface.xhtml
diff --git a/third_party/WebKit/LayoutTests/transforms/cssmatrix-2d-interface.xhtml b/third_party/WebKit/LayoutTests/transforms/cssmatrix-2d-interface.xhtml
index ed7b00cc1487bc4dd93cb6b40927e6caf93f9806..cc8553662e791244941502374dd6c60479f83140 100644
--- a/third_party/WebKit/LayoutTests/transforms/cssmatrix-2d-interface.xhtml
+++ b/third_party/WebKit/LayoutTests/transforms/cssmatrix-2d-interface.xhtml
@@ -255,12 +255,7 @@ debug("");
debug("Test multiply with missing argument");
m = new WebKitCSSMatrix("matrix(1, 2, 3, 4, 5, 6)");
m2 = m.multiply();
-shouldBe('m2.a', '1');
-shouldBe('m2.b', '2');
-shouldBe('m2.c', '3');
-shouldBe('m2.d', '4');
-shouldBe('m2.e', '5');
-shouldBe('m2.f', '6');
+shouldBe('m2', 'null');
debug("");
debug("Test inverse");
@@ -284,25 +279,9 @@ shouldBe('parseFloat(m.e)', '10');
shouldBe('parseFloat(m.f)', '20');
debug("");
-debug("Test not invertible matrix");
+debug("Test throwing exception from inverse");
m = new WebKitCSSMatrix("matrix(0, 0, 0, 0, 0, 0)"); // not invertible
-m2 = m.inverse();
-
-shouldBeNaN('m2.a');
-shouldBeNaN('m2.b');
-shouldBeNaN('m2.c');
-shouldBeNaN('m2.d');
-shouldBeNaN('m2.e');
-shouldBeNaN('m2.f');
-
-debug("");
-debug("Test immutability of inverse");
-shouldBe('m.a', '0');
-shouldBe('m.b', '0');
-shouldBe('m.c', '0');
-shouldBe('m.d', '0');
-shouldBe('m.e', '0');
-shouldBe('m.f', '0');
+shouldThrow('m.inverse()');
debug("");

Powered by Google App Engine
This is Rietveld 408576698